Category dashboard with collapsible filters#934
Conversation
rviscomi
left a comment
There was a problem hiding this comment.
Staged here and left a bunch of feedback: https://technology-report-dot-httparchive.uk.r.appspot.com/reports/techreport/category?geo=ALL&rank=ALL&category=CMS
I had to patch one bug to get it to work (the fix is in one of the comment suggestions) but otherwise these are all just feature requests. Great work!
|
|
||
| console.log(sortMetric); | ||
| if(sortMetric) { | ||
| this.dataArray = this.dataArray.sort((techA, techB) => { |
There was a problem hiding this comment.
I was able to work around the error below by filtering out empty arrays before sorting. Not sure if it's the best fix though.
| this.dataArray = this.dataArray.sort((techA, techB) => { | |
| this.dataArray = this.dataArray.filter(tech => tech.length).sort((techA, techB) => { |
Co-authored-by: Rick Viscomi <rviscomi@users.noreply.github.com>
…summary, improve landing page card interaction
|
@rviscomi - I made a lot of updates based on the feedback you left, and created follow-up action items for the larger todos (sorting of the table f.ex) so those can go in a follow-up PR. Also fixed a few other things at the same time, like removing/replacing the placeholder texts and making the navigation responsive (hamburger menu). So it's ready for re-review :) |
tunetheweb
left a comment
There was a problem hiding this comment.
OK I think this is good to merge!
New features
/reports/techreport/category/reports/techreport/tech(Visual) Improvements
aria-expanded)Bugfixes
Screenshots
Technologies
One technology
Multiple technologies
Desktop
Mobile
Categories