Refactor Existing Test Script and Add New Unit Tests for GCE Billing#516
Merged
mambelli merged 6 commits intoHEPCloud:masterfrom May 7, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #516 +/- ##
==========================================
+ Coverage 47.84% 47.92% +0.07%
==========================================
Files 54 54
Lines 2951 2940 -11
Branches 510 441 -69
==========================================
- Hits 1412 1409 -3
+ Misses 1439 1438 -1
+ Partials 100 93 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- addressed CI errors for ruff and flake8 - includes a second test using an fake credential that has an invalid key - updated tests to reflect correct PEP8-compliant method names - updated the PEP8-compliant method name in GCEBillingInfo module
namrathaurs
force-pushed
the
fix-unit-tests-gcebilling-v2
branch
from
4f2e20c to
b2fef1f
Compare
namrathaurs
changed the title
mambelli
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the modifications to the existing test script for GCE Billing in Decision Engine modules. As the cloud billing analysis code was migrated to BigQuery in the recent past, a part of existing test script became obsolete since the previous class methods in
GCEBillCalculatorno longer exist/have changed. To reflect the new version of the billing code, new unit tests are introduced through this pull request.