feat: add soft-drop table recovery procedures by v0y4g3r · Pull Request #8061 · GreptimeTeam/greptimedb

v0y4g3r · 2026-05-03T11:10:06Z

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Refs https://github.com/GreptimeTeam/greptimedb-enterprise/issues/851

Related proto PR: GreptimeTeam/greptime-proto#318

What's changed and what's your intention?

This PR implements Tasks 3 and 4 of the soft-drop table plan.

Adds close-first soft-drop behavior for DROP TABLE when soft-drop is enabled: metadata is tombstoned, caches are invalidated, regions are closed, and physical cleanup is deferred.
Adds UndropTableProcedure to restore tombstoned metadata, reopen preserved physical regions, refresh cache state, and re-register failure detectors.
Adds PurgeDroppedTableProcedure to resolve tombstoned tables, reopen closed physical regions before issuing real drop requests, delete tombstones, and deregister failure detectors.
Wires the new DDL task variants, procedure loaders, protobuf conversions, and submit/dispatch paths.
Keeps metric-engine logical soft-drop/undrop/purge unsupported for now to avoid closing or dropping shared physical metric regions through logical table operations.

Undrop table procedure flow

UNDROP TABLE is table-id based and restores the tombstoned table through these steps:

Prepare: load the dropped-table tombstone by table id, recover the original table name, table info, route, and WAL options, reject unsupported metric logical tables, and verify that the live table name does not already exist.
OpenRegions: for physical tables, reopen preserved regions from the tombstone-derived table info, route, and WAL options before the table metadata becomes live again. Logical tables skip datanode region open and proceed directly to metadata restore.
RestoreMetadata: atomically move tombstoned metadata back to live metadata keys. The restore transaction requires destination keys to be absent, so a concurrent same-name table creation fails the undrop with TableAlreadyExists instead of overwriting live metadata.
InvalidateTableCache: invalidate table-name and table-id cache entries after metadata is restored.

Design considerations

UNDROP and PURGE use table-id-only tasks to avoid caller-supplied table-name/table-id mismatches. The original table name is authoritative from the tombstone.
The procedure opens physical regions before restoring live metadata. This avoids exposing a restored table whose regions are still closed.
The procedure does not explicitly wait for reopened leader regions to become writable leaders before restoring metadata. A reopened Mito leader region can temporarily be follower/read-only until heartbeat lease convergence promotes it back to leader. During that short window, writes may return RegionNotReady and should be retried. Waiting inside UNDROP would keep the table invisible for the same convergence window and add extra state/registry waiting complexity without removing the transient inability to write.
The restore path still guards against concurrent live-name creation with metadata-level destination-exists checks, because the tombstone table name is only known after Prepare and cannot be protected solely by the initial lock key.

Current limitation:

Soft-drop recovery currently supports physical table region lifecycle. Metric logical tables are explicitly rejected for soft-drop, undrop, and purge until a dedicated logical-table design is added.

Test plan run during development:

cargo nextest run -p common-meta drop_table
cargo nextest run -p common-meta undrop purge_dropped
cargo nextest run -p mito2 test_engine_reopens_closed_soft_dropped_region
cargo check -p common-meta --all-targets

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

I have written the necessary rustdoc comments.
I have added the necessary unit tests and integration tests.
This PR requires documentation updates.
API changes are backward compatible.
Schema or data changes are backward compatible.

gemini-code-assist

Code Review

This pull request introduces a "soft drop" feature, enabling tables to be tombstoned instead of immediately deleted. It adds new procedures for undropping and purging tables, along with a soft_drop_enabled configuration in the DDL context. Review feedback highlights that the open_regions logic in the undrop procedure is incomplete as it only reopens leader regions, potentially leaving replicated tables without their follower replicas. Suggestions were made to include HashSet and follower-related routing imports to correctly restore the full replication state.

Copilot

Pull request overview

This PR adds metasrv-side procedure support for table soft-drop recovery, introducing explicit UNDROP and PURGE workflows and updating the existing DROP TABLE procedure to support a “tombstone + close regions” path when soft-drop is enabled.

Changes:

Add UndropTableProcedure to restore tombstoned metadata and reopen preserved regions.
Add PurgeDroppedTableProcedure to permanently drop regions for tombstoned tables and delete tombstones.
Extend DDL task/procedure plumbing (task variants, protobuf conversions, loaders/dispatch) and add test coverage for soft-drop/undrop/purge behavior.

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests-integration/src/standalone.rs	Initializes new `DdlContext.soft_drop_enabled` field in integration standalone builder.
src/mito2/src/engine/open_test.rs	Strengthens reopen test by inserting rows pre-reopen and validating scan results post-reopen.
src/meta-srv/src/procedure/utils.rs	Updates metasrv procedure test context to include `soft_drop_enabled`.
src/meta-srv/src/metasrv/builder.rs	Wires `soft_drop_enabled` into metasrv DDL context (currently hardcoded false).
src/common/meta/src/test_util.rs	Updates common-meta test DDL contexts to include `soft_drop_enabled`.
src/common/meta/src/rpc/ddl.rs	Adds `UndropTable` and `PurgeDroppedTable` DDL tasks + protobuf roundtrip tests.
src/common/meta/src/key.rs	Improves dropped-table WAL options reconstruction to tolerate logical routes.
src/common/meta/src/error.rs	Adds `TableNameTombstoneConflict` error and maps it to `TableAlreadyExists`.
src/common/meta/src/ddl/utils.rs	Adds helper `is_metric_engine_logical_table()` for soft-drop gating logic.
src/common/meta/src/ddl/undrop_table.rs	New undrop procedure: restore tombstones, reopen regions, invalidate cache, re-register failure detectors.
src/common/meta/src/ddl/tests/drop_table.rs	Adds extensive tests for soft-drop, name conflict semantics, undrop, purge, and metric-engine logical table rejection.
src/common/meta/src/ddl/purge_dropped_table.rs	New purge procedure: resolve tombstone, reopen regions (if physical), drop, delete tombstones, deregister failure detectors.
src/common/meta/src/ddl/drop_table/metadata.rs	Adds soft-drop gating for metric-engine logical tables and refactors metadata fetch flow.
src/common/meta/src/ddl/drop_table/executor.rs	Adds tombstone-name conflict check for dropping recreated tables; adds close-regions path.
src/common/meta/src/ddl/drop_table.rs	Implements soft-drop branch: close regions + deregister detectors and stop before physical drop.
src/common/meta/src/ddl.rs	Adds `soft_drop_enabled` to `DdlContext`; exposes detector deregistration to crate.
src/common/meta/src/ddl_manager.rs	Registers/dispatches new procedures and adds submit helpers for undrop/purge tasks.
src/cmd/src/standalone.rs	Initializes new `DdlContext.soft_drop_enabled` field for standalone command.
Cargo.toml	Updates `greptime-proto` git revision.
Cargo.lock	Lockfile update following `greptime-proto` revision bump.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

WenyXu · 2026-05-08T11:58:21Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0fc2f8d8a2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Soft-drop now tombstones table metadata and closes datanode regions instead of issuing physical drop requests, while preserving hard-drop cleanup semantics and blocking conflicting drops of recreated table names. Files: - `src/common/meta/src/ddl.rs` - `src/common/meta/src/ddl/drop_table.rs` - `src/common/meta/src/ddl/drop_table/executor.rs` - `src/common/meta/src/error.rs` - `src/common/meta/src/ddl_manager.rs` - `src/meta-srv/src/metasrv/builder.rs` - `src/cmd/src/standalone.rs` - `src/common/meta/src/test_util.rs` - `src/meta-srv/src/procedure/utils.rs` - `tests-integration/src/standalone.rs` - `src/common/meta/src/ddl/tests/drop_table.rs` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>

Add soft-drop recovery and cleanup procedures, wire their DDL task handling, and update \`greptime-proto\` so the new tasks can round-trip through protobuf. Files: - \`Cargo.toml\` - \`Cargo.lock\` - \`src/common/meta/src/ddl.rs\` - \`src/common/meta/src/ddl/undrop_table.rs\` - \`src/common/meta/src/ddl/purge_dropped_table.rs\` - \`src/common/meta/src/ddl_manager.rs\` - \`src/common/meta/src/rpc/ddl.rs\` - \`src/common/meta/src/key.rs\` - \`src/common/meta/src/ddl/tests/drop_table.rs\` - \`src/mito2/src/engine/open_test.rs\` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>

Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>

Prevent soft-dropping, undropping, and purging of metric engine logical tables by explicitly returning unsupported errors. This introduces `is_metric_engine_logical_table` to identify metric logical tables and adds corresponding test cases. Files: - `src/common/meta/src/ddl/drop_table/metadata.rs` - `src/common/meta/src/ddl/purge_dropped_table.rs` - `src/common/meta/src/ddl/tests/drop_table.rs` - `src/common/meta/src/ddl/undrop_table.rs` - `src/common/meta/src/ddl/utils.rs` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>

Keep region failure detector state aligned as soft-dropped tables close, reopen, and purge regions so stale detectors do not trigger failover for unavailable or deleted regions. Files: - \`src/common/meta/src/ddl.rs\` - \`src/common/meta/src/ddl/drop_table.rs\` - \`src/common/meta/src/ddl/undrop_table.rs\` - \`src/common/meta/src/ddl/purge_dropped_table.rs\` - \`src/common/meta/src/ddl/tests/drop_table.rs\` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>

Consolidate redundant soft-drop lifecycle assertions into existing end-to-end tests and share dropped-table metadata setup to keep the branch coverage focused. Files: - `src/common/meta/src/ddl/tests/drop_table.rs` - `src/common/meta/src/key.rs` - `src/mito2/src/engine/open_test.rs` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>

Reopen all replicas when restoring dropped physical tables so recovered replicated tables do not leave follower regions closed. Files: - `src/common/meta/src/ddl/undrop_table.rs` - `src/common/meta/src/ddl/tests/drop_table.rs` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>

Update greptime-proto and adapt dropped table DDL task conversions to the shared expression wrappers required by the proto API. Files: - `Cargo.toml` - `Cargo.lock` - `src/api/src/helper.rs` - `src/common/meta/src/ddl/drop_table/executor.rs` - `src/common/meta/src/rpc/ddl.rs` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>

Point GreptimeDB at the proto revision that restores direct dropped table task fields and remove wrapper-expression conversion code. Files: - `Cargo.toml` - `Cargo.lock` - `src/api/src/helper.rs` - `src/common/meta/src/rpc/ddl.rs` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>

- Bump `greptime-proto` dependency revision (`Cargo.toml`, `Cargo.lock`) - Pass `region_wal_options` directly without pre-serialization in undrop flow (`src/common/meta/src/ddl/undrop_table.rs`, `src/common/meta/src/key.rs`) - Remove unused `RegionNumber` import (`src/common/meta/src/ddl/utils.rs`) - Add `reset_failure_detectors` to test mock (`src/common/meta/src/ddl/tests/drop_table.rs`) - Add JSON roundtrip tests for `UndropTableTask` and `PurgeDroppedTableTask` (`src/common/meta/src/rpc/ddl.rs`) Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>

Add a guard in `UndropTableProcedure::on_prepare()` to check that the dropped table name matches the undrop task name, returning `TableNotFound` on mismatch. This prevents undropping a table by a different name when only the table ID is known. - `src/common/meta/src/ddl/undrop_table.rs` — add table-name validation - `src/common/meta/src/ddl/tests/drop_table.rs` — add test for name mismatch Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>

Remove catalog, schema, and table name fields from `UndropTableTask` since the table name can be derived from the dropped table metadata in the procedure itself. This eliminates redundant fields and the associated name-validation test. Simplify locking in `UndropTableProcedure` to only use `TableLock`. Update `greptime-proto` dependency revision. - `Cargo.toml`, `Cargo.lock` - `src/common/meta/src/rpc/ddl.rs` - `src/common/meta/src/ddl/undrop_table.rs` - `src/common/meta/src/ddl/tests/drop_table.rs` Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>

- Added `require_dest_not_exists` parameter to tombstone `move_values` to check destination key existence during restore - Added `TombstoneTargetAlreadyExists` error variant - Map tombstone conflict to `TableAlreadyExists` in undrop procedure - Added test for undrop failing when live name created after prepare Files: - `src/common/meta/src/ddl/tests/drop_table.rs` - `src/common/meta/src/ddl/undrop_table.rs` - `src/common/meta/src/error.rs` - `src/common/meta/src/key/tombstone.rs` Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>

Streamline the purge-dropped-table flow by requiring a table_id instead of allowing name-based fallback. - Refactored `PurgeDroppedTableTask` to hold only `table_id` in `src/common/meta/src/rpc/ddl.rs` - Simplified purge procedure in `src/common/meta/src/ddl/purge_dropped_table.rs` - Adapted tests in `src/common/meta/src/ddl/tests/drop_table.rs` - Bumped `greptime-proto` dependency Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>

Replaced the fixed `max_txn_ops() / 2` chunk size with operation-aware constants (`MOVE_VALUE_TXN_OPS_PER_KEY=4`, `RESTORE_VALUE_TXN_OPS_PER_KEY=6`) to correctly account for per-key transaction operations. Added `TxnOpLimitKvBackend` test helper and two new tests (`test_restore_chunks_by_total_txn_ops_limit`, `test_create_chunks_by_total_txn_ops_limit`) verifying chunking under tight txn op limits. Affected file: - `src/common/meta/src/key/tombstone.rs` — chunk size fix, `TxnOpLimitKvBackend` helper, two new tests Signed-off-by: Lei, HUANG <ratuthomm@gmail.com> Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>

…n-regions during purge - `src/common/meta/src/ddl/drop_table.rs`: deregister failure detectors before transitioning to DeleteTombstone state - `src/common/meta/src/ddl/undrop_table.rs`: refactor `open_regions` into `open_regions_inner` with an `ignore_region_not_found` flag; expose `open_regions_ignore_region_not_found` for purge replayer - `src/common/meta/src/ddl/purge_dropped_table.rs`: use `open_regions_ignore_region_not_found` in replayed purge procedures - `src/common/meta/src/ddl/tests/drop_table.rs`: add tests for undrop idempotency and purge replay tolerance of dropped regions Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>

Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>

Copilot

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.

v0y4g3r · 2026-07-02T08:40:58Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 226ed5f8e9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Restore undropped table metadata only after physical regions have been reopened, keeping the table hidden while regions are still closed. Preserve the live-name conflict check before opening regions and cover the ordering with a regression test. Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>

Fail before issuing `TombstoneManager` transactions when the configured `max_txn_ops` cannot fit one key. Add coverage for undersized restore budgets in `src/common/meta/src/key/tombstone.rs`. Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>

fengjiachun

LGTM

Copilot

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.

Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>

* feat: add close-first soft-drop table flow Soft-drop now tombstones table metadata and closes datanode regions instead of issuing physical drop requests, while preserving hard-drop cleanup semantics and blocking conflicting drops of recreated table names. Files: - `src/common/meta/src/ddl.rs` - `src/common/meta/src/ddl/drop_table.rs` - `src/common/meta/src/ddl/drop_table/executor.rs` - `src/common/meta/src/error.rs` - `src/common/meta/src/ddl_manager.rs` - `src/meta-srv/src/metasrv/builder.rs` - `src/cmd/src/standalone.rs` - `src/common/meta/src/test_util.rs` - `src/meta-srv/src/procedure/utils.rs` - `tests-integration/src/standalone.rs` - `src/common/meta/src/ddl/tests/drop_table.rs` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> * feat: add undrop and purge table procedures Add soft-drop recovery and cleanup procedures, wire their DDL task handling, and update \`greptime-proto\` so the new tasks can round-trip through protobuf. Files: - \`Cargo.toml\` - \`Cargo.lock\` - \`src/common/meta/src/ddl.rs\` - \`src/common/meta/src/ddl/undrop_table.rs\` - \`src/common/meta/src/ddl/purge_dropped_table.rs\` - \`src/common/meta/src/ddl_manager.rs\` - \`src/common/meta/src/rpc/ddl.rs\` - \`src/common/meta/src/key.rs\` - \`src/common/meta/src/ddl/tests/drop_table.rs\` - \`src/mito2/src/engine/open_test.rs\` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> * fix: reopen soft-dropped regions before purge Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> * feat: disable soft-drop operations for metric logical tables Prevent soft-dropping, undropping, and purging of metric engine logical tables by explicitly returning unsupported errors. This introduces `is_metric_engine_logical_table` to identify metric logical tables and adds corresponding test cases. Files: - `src/common/meta/src/ddl/drop_table/metadata.rs` - `src/common/meta/src/ddl/purge_dropped_table.rs` - `src/common/meta/src/ddl/tests/drop_table.rs` - `src/common/meta/src/ddl/undrop_table.rs` - `src/common/meta/src/ddl/utils.rs` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> * fix: sync failure detectors during soft-drop lifecycle Keep region failure detector state aligned as soft-dropped tables close, reopen, and purge regions so stale detectors do not trigger failover for unavailable or deleted regions. Files: - \`src/common/meta/src/ddl.rs\` - \`src/common/meta/src/ddl/drop_table.rs\` - \`src/common/meta/src/ddl/undrop_table.rs\` - \`src/common/meta/src/ddl/purge_dropped_table.rs\` - \`src/common/meta/src/ddl/tests/drop_table.rs\` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> * refactor: simplify soft-drop table tests Consolidate redundant soft-drop lifecycle assertions into existing end-to-end tests and share dropped-table metadata setup to keep the branch coverage focused. Files: - `src/common/meta/src/ddl/tests/drop_table.rs` - `src/common/meta/src/key.rs` - `src/mito2/src/engine/open_test.rs` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> * fix: reopen follower regions during undrop Reopen all replicas when restoring dropped physical tables so recovered replicated tables do not leave follower regions closed. Files: - `src/common/meta/src/ddl/undrop_table.rs` - `src/common/meta/src/ddl/tests/drop_table.rs` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> * feat: use dropped table ddl expr protos Update greptime-proto and adapt dropped table DDL task conversions to the shared expression wrappers required by the proto API. Files: - `Cargo.toml` - `Cargo.lock` - `src/api/src/helper.rs` - `src/common/meta/src/ddl/drop_table/executor.rs` - `src/common/meta/src/rpc/ddl.rs` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> * revert: use inline dropped table task protos Point GreptimeDB at the proto revision that restores direct dropped table task fields and remove wrapper-expression conversion code. Files: - `Cargo.toml` - `Cargo.lock` - `src/api/src/helper.rs` - `src/common/meta/src/rpc/ddl.rs` Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> * feat: various soft-drop improvements - Bump `greptime-proto` dependency revision (`Cargo.toml`, `Cargo.lock`) - Pass `region_wal_options` directly without pre-serialization in undrop flow (`src/common/meta/src/ddl/undrop_table.rs`, `src/common/meta/src/key.rs`) - Remove unused `RegionNumber` import (`src/common/meta/src/ddl/utils.rs`) - Add `reset_failure_detectors` to test mock (`src/common/meta/src/ddl/tests/drop_table.rs`) - Add JSON roundtrip tests for `UndropTableTask` and `PurgeDroppedTableTask` (`src/common/meta/src/rpc/ddl.rs`) Signed-off-by: Lei, HUANG <ratuthomm@gmail.com> * feat: validate table name match in undrop procedure Add a guard in `UndropTableProcedure::on_prepare()` to check that the dropped table name matches the undrop task name, returning `TableNotFound` on mismatch. This prevents undropping a table by a different name when only the table ID is known. - `src/common/meta/src/ddl/undrop_table.rs` — add table-name validation - `src/common/meta/src/ddl/tests/drop_table.rs` — add test for name mismatch Signed-off-by: Lei, HUANG <ratuthomm@gmail.com> * refactor: simplify UndropTableTask to use table_id only Remove catalog, schema, and table name fields from `UndropTableTask` since the table name can be derived from the dropped table metadata in the procedure itself. This eliminates redundant fields and the associated name-validation test. Simplify locking in `UndropTableProcedure` to only use `TableLock`. Update `greptime-proto` dependency revision. - `Cargo.toml`, `Cargo.lock` - `src/common/meta/src/rpc/ddl.rs` - `src/common/meta/src/ddl/undrop_table.rs` - `src/common/meta/src/ddl/tests/drop_table.rs` Signed-off-by: Lei, HUANG <ratuthomm@gmail.com> * feat: detect table name conflict during tombstone restore in undrop - Added `require_dest_not_exists` parameter to tombstone `move_values` to check destination key existence during restore - Added `TombstoneTargetAlreadyExists` error variant - Map tombstone conflict to `TableAlreadyExists` in undrop procedure - Added test for undrop failing when live name created after prepare Files: - `src/common/meta/src/ddl/tests/drop_table.rs` - `src/common/meta/src/ddl/undrop_table.rs` - `src/common/meta/src/error.rs` - `src/common/meta/src/key/tombstone.rs` Signed-off-by: Lei, HUANG <ratuthomm@gmail.com> * feat: make PurgeDroppedTableTask table_id-only Streamline the purge-dropped-table flow by requiring a table_id instead of allowing name-based fallback. - Refactored `PurgeDroppedTableTask` to hold only `table_id` in `src/common/meta/src/rpc/ddl.rs` - Simplified purge procedure in `src/common/meta/src/ddl/purge_dropped_table.rs` - Adapted tests in `src/common/meta/src/ddl/tests/drop_table.rs` - Bumped `greptime-proto` dependency Signed-off-by: Lei, HUANG <ratuthomm@gmail.com> * fix(tombstone): chunk values by per-key txn ops instead of fixed divisor Replaced the fixed `max_txn_ops() / 2` chunk size with operation-aware constants (`MOVE_VALUE_TXN_OPS_PER_KEY=4`, `RESTORE_VALUE_TXN_OPS_PER_KEY=6`) to correctly account for per-key transaction operations. Added `TxnOpLimitKvBackend` test helper and two new tests (`test_restore_chunks_by_total_txn_ops_limit`, `test_create_chunks_by_total_txn_ops_limit`) verifying chunking under tight txn op limits. Affected file: - `src/common/meta/src/key/tombstone.rs` — chunk size fix, `TxnOpLimitKvBackend` helper, two new tests Signed-off-by: Lei, HUANG <ratuthomm@gmail.com> Signed-off-by: Lei, HUANG <ratuthomm@gmail.com> * feat(soft-drop): deregister failure detectors and handle replayed open-regions during purge - `src/common/meta/src/ddl/drop_table.rs`: deregister failure detectors before transitioning to DeleteTombstone state - `src/common/meta/src/ddl/undrop_table.rs`: refactor `open_regions` into `open_regions_inner` with an `ignore_region_not_found` flag; expose `open_regions_ignore_region_not_found` for purge replayer - `src/common/meta/src/ddl/purge_dropped_table.rs`: use `open_regions_ignore_region_not_found` in replayed purge procedures - `src/common/meta/src/ddl/tests/drop_table.rs`: add tests for undrop idempotency and purge replay tolerance of dropped regions Signed-off-by: Lei, HUANG <ratuthomm@gmail.com> * chore: fix clippy Signed-off-by: Lei, HUANG <ratuthomm@gmail.com> * fix(soft-drop): open regions before restoring undrop metadata Restore undropped table metadata only after physical regions have been reopened, keeping the table hidden while regions are still closed. Preserve the live-name conflict check before opening regions and cover the ordering with a regression test. Signed-off-by: Lei, HUANG <ratuthomm@gmail.com> * fix(tombstone): fail fast on invalid txn op budget Fail before issuing `TombstoneManager` transactions when the configured `max_txn_ops` cannot fit one key. Add coverage for undersized restore budgets in `src/common/meta/src/key/tombstone.rs`. Signed-off-by: Lei, HUANG <ratuthomm@gmail.com> * chore: bump greptime-proto to main branch commit Signed-off-by: Lei, HUANG <ratuthomm@gmail.com> --------- Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> Signed-off-by: Lei, HUANG <ratuthomm@gmail.com> Signed-off-by: Lei, HUANG <ratuthomm@gmail.com> Signed-off-by: onepizzateam <palakjha916@gmail.com>

github-actions Bot added size/XL docs-not-required This change does not impact docs. labels May 3, 2026

gemini-code-assist Bot reviewed May 3, 2026

View reviewed changes

Comment thread src/common/meta/src/ddl/undrop_table.rs Outdated

Comment thread src/common/meta/src/ddl/undrop_table.rs Outdated

Comment thread src/common/meta/src/ddl/undrop_table.rs Outdated

github-actions Bot added size/XXL and removed size/XL labels May 3, 2026

v0y4g3r mentioned this pull request May 6, 2026

feat: add dropped table ddl tasks GreptimeTeam/greptime-proto#318

Merged

2 tasks

v0y4g3r marked this pull request as ready for review May 7, 2026 03:00

Copilot AI review requested due to automatic review settings May 7, 2026 03:00

v0y4g3r requested review from a team, MichaelScofield, WenyXu, evenyag and waynexia as code owners May 7, 2026 03:00

Copilot started reviewing on behalf of v0y4g3r May 7, 2026 03:00 View session

Copilot AI reviewed May 7, 2026

View reviewed changes

Comment thread src/common/meta/src/ddl/undrop_table.rs

Comment thread src/common/meta/src/ddl/purge_dropped_table.rs

Comment thread src/common/meta/src/ddl/purge_dropped_table.rs

Comment thread src/meta-srv/src/metasrv/builder.rs

chatgpt-codex-connector Bot reviewed May 8, 2026

View reviewed changes

Comment thread src/common/meta/src/ddl/undrop_table.rs Outdated

v0y4g3r marked this pull request as draft May 12, 2026 07:39

v0y4g3r force-pushed the feat/soft-drop-task4 branch from 0fc2f8d to a1f06e0 Compare July 1, 2026 11:57

v0y4g3r and others added 11 commits July 2, 2026 14:35

fix: reopen soft-dropped regions before purge

91900ad

Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>

v0y4g3r added 4 commits July 2, 2026 14:44

v0y4g3r force-pushed the feat/soft-drop-task4 branch from 20cc80f to a6e116a Compare July 2, 2026 06:48

v0y4g3r added 2 commits July 2, 2026 15:42

chore: fix clippy

226ed5f

Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>

v0y4g3r marked this pull request as ready for review July 2, 2026 08:07

WenyXu requested a review from Copilot July 2, 2026 08:10

Copilot started reviewing on behalf of WenyXu July 2, 2026 08:10 View session

Copilot AI reviewed Jul 2, 2026

View reviewed changes

Comment thread src/common/meta/src/key/tombstone.rs Outdated

chatgpt-codex-connector Bot reviewed Jul 2, 2026

View reviewed changes

Comment thread src/common/meta/src/ddl/undrop_table.rs

Comment thread src/common/meta/src/ddl/undrop_table.rs

v0y4g3r added 2 commits July 2, 2026 17:44

fengjiachun approved these changes Jul 2, 2026

View reviewed changes

WenyXu approved these changes Jul 3, 2026

View reviewed changes

WenyXu requested a review from Copilot July 3, 2026 10:32

Copilot started reviewing on behalf of WenyXu July 3, 2026 10:33 View session

Copilot AI reviewed Jul 3, 2026

View reviewed changes

Comment thread src/common/meta/src/ddl/tests/drop_table.rs

chore: bump greptime-proto to main branch commit

10796a1

Signed-off-by: Lei, HUANG <ratuthomm@gmail.com>

v0y4g3r enabled auto-merge July 5, 2026 08:07

v0y4g3r added this pull request to the merge queue Jul 5, 2026

Merged via the queue into GreptimeTeam:main with commit 3758911 Jul 5, 2026
50 checks passed

v0y4g3r deleted the feat/soft-drop-task4 branch July 5, 2026 09:41

Uh oh!

Conversation

v0y4g3r commented May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Undrop table procedure flow

Design considerations

PR Checklist

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WenyXu commented May 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

v0y4g3r commented Jul 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

fengjiachun left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

v0y4g3r commented May 3, 2026 •

edited

Loading