build: relax linter config for maintenance mode in release/0.12#1829
Closed
hsmatulis wants to merge 1 commit intorelease/0.12from
Closed
build: relax linter config for maintenance mode in release/0.12#1829hsmatulis wants to merge 1 commit intorelease/0.12from
hsmatulis wants to merge 1 commit intorelease/0.12from
Conversation
This was referenced Dec 12, 2025
Switch golangci-lint from `enable-all: true` strategy to an allowlist. The release/0.12 branch is strictly for dependency updates & vulnerability fixes. The previous configuration caused unrelated build failures whenever golangci-lint added new linters (e.g., `usetesting`) or updated style rules (e.g., `revive`).
68fd2be to
edf811b
Compare
bernot-dev
requested changes
Dec 12, 2025
Collaborator
bernot-dev
left a comment
There was a problem hiding this comment.
We'll just disable or ignore the linter on release branches.
Collaborator
|
Seemed we agree to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch golangci-lint from
enable-all: truestrategy to an allowlist one. The release/0.12 branch is strictly for dependency updates & vulnerability fixes.The previous configuration caused unrelated build failures whenever golangci-lint added new linters (e.g.,
usetesting) or updated style rules (e.g.,revive).