Closed
Conversation
bwplotka
force-pushed
the
forkscript
branch
3 times, most recently
from
668c227 to
2dbf5c2
Compare
Contributor
|
I like the ideas here! However, the plan is to have |
Collaborator
Author
|
What's trigger_rc? There are set of script I based on, that's why basing on those. Let's sync internally, especially I wonder if the prepare_rc is complex enough for Go code 🤔 also at this point it does not prepare rc really (e.g. it does not regenerate manifests), so technically it's "update tags" or something. |
Also refactored hack/cmd/prepare_rc for reliability. Signed-off-by: bwplotka <bwplotka@google.com>
Collaborator
Author
|
Will create a separate PR with a clean state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also refactored hack/cmd/prepare_rc for reliability.
Depends on #1699