Skip to content

feat(firestore-multimodal-genai): Add support for Gemini 2.5 models#724

Merged
cabljac merged 10 commits intomainfrom
@invertase/firestore-multimodal-genai-gemini2.5-support
Jul 22, 2025
Merged

feat(firestore-multimodal-genai): Add support for Gemini 2.5 models#724
cabljac merged 10 commits intomainfrom
@invertase/firestore-multimodal-genai-gemini2.5-support

Conversation

@HassanBahati
Copy link
Copy Markdown
Contributor

Fixes #717

@HassanBahati HassanBahati changed the title feat(firestore-multimodal-genai): feat: Add support for Gemini 2.5 models feat(firestore-multimodal-genai): Add support for Gemini 2.5 models Jul 15, 2025
@HassanBahati HassanBahati marked this pull request as ready for review July 18, 2025 07:46
@HassanBahati HassanBahati requested review from CorieW and cabljac July 18, 2025 07:46
@cabljac cabljac requested a review from Copilot July 18, 2025 09:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Gemini 2.5 models to the firestore-multimodal-genai extension while removing deprecated Gemini models. The implementation updates both GoogleAI and VertexAI providers to include the new Gemini 2.5 model variants.

  • Adds support for three new Gemini 2.5 models: FlashPreview0417, ProExp0325, and ProPreview0325
  • Removes deprecated Gemini models including older experimental and preview versions
  • Updates package dependencies to support the new models and removes outdated test configurations

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
functions/src/generative-client/genkit.ts Updates model imports and references to add Gemini 2.5 models and remove deprecated ones
functions/package.json Upgrades genkit-ai dependencies from v1.3.0/v1.9.0 to v1.14.1
functions/tests/vertex_ai/index.test.ts Updates test configuration to use gemini-2.5-pro instead of gemini-1.0-pro
functions/tests/vertex_ai/images.test.ts Updates test configuration to use gemini-2.5-pro instead of gemini-1.0-pro
functions/tests/google_ai/index.test.ts Updates test configuration to use gemini-2.5-pro instead of gemini-1.0-pro
functions/tests/google_ai/images.test.ts Updates test configuration to use gemini-2.5-pro instead of gemini-1.0-pro
functions/tests/genkit/client.test.ts Updates mock configurations to use gemini-2.5-pro instead of gemini-1.0-pro
extension.yaml Bumps extension version from 1.0.4 to 1.0.5
CHANGELOG.md Documents the addition of Gemini 2.5 support and removal of deprecated models
Files not reviewed (1)
  • firestore-multimodal-genai/functions/package-lock.json: Language not supported
Comments suppressed due to low confidence (2)

firestore-multimodal-genai/functions/tests/genkit/client.test.ts:27

  • The test mocks are using 'gemini25Pro' but the actual code imports 'gemini25FlashPreview0417', 'gemini25ProExp0325', and 'gemini25ProPreview0325'. The mock should reflect the actual model variants being used in the implementation.
  gemini25Pro: {name: 'googleai/gemini-2.5-pro', withVersion: jest.fn()},

firestore-multimodal-genai/functions/tests/genkit/client.test.ts:34

  • The test mocks are using 'gemini25Pro' but the actual code imports 'gemini25FlashPreview0417', 'gemini25ProExp0325', and 'gemini25ProPreview0325'. The mock should reflect the actual model variants being used in the implementation.
  gemini25Pro: {name: 'vertexai/gemini-2.5-pro', withVersion: jest.fn()},

Copy link
Copy Markdown
Collaborator

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can we double check the update to README to make sure it's accurate to what we're doing?
  • Can we add a note to the model param in the extension.yaml to let people know about deprecation/retiring of models

@github-project-automation github-project-automation bot moved this to Changes Requested [PR] in [Cloud] Extensions + Functions Jul 18, 2025
Copy link
Copy Markdown
Collaborator

@CorieW CorieW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new models don't seem to have been exported correctly in Genkit. Access them by using something like vertexAI.model(model) or googleAI.model(model).

For example: googleAI.model('gemini-2.5-pro'). This works.

@HassanBahati HassanBahati force-pushed the @invertase/firestore-multimodal-genai-gemini2.5-support branch from 87c7948 to d7ede90 Compare July 22, 2025 09:15
@HassanBahati HassanBahati mentioned this pull request Jul 22, 2025
11 tasks
@cabljac cabljac force-pushed the @invertase/firestore-multimodal-genai-gemini2.5-support branch from 9637fe3 to a210468 Compare July 22, 2025 15:17
@cabljac cabljac merged commit c9601ef into main Jul 22, 2025
9 of 10 checks passed
@cabljac cabljac deleted the @invertase/firestore-multimodal-genai-gemini2.5-support branch July 22, 2025 16:18
@github-project-automation github-project-automation bot moved this from Changes Requested [PR] to Done in [Cloud] Extensions + Functions Jul 22, 2025
andyma-star pushed a commit to andyma-star/firebase-extensions that referenced this pull request Mar 12, 2026
…oogleCloudPlatform#724)

* feat(firestore-multimodal-genai): feat: Add support for Gemini 2.5 models

* chore(firestore-multimodal-genai): remove gemini20ProExp0205

* chore(firestore-multimodal-genai): remove deprecated models

* test(firestore-multimodal-genai): swap gemini-1.0-pro => gemini-2.5-pro

* test(firestore-multimodal-genai): remove deprecated gemini-1.0-pro

* docs(firestore-multimodal-genai): update changelog

* refactor(firestore-multimodal-genai): correctly call gemini-2.5-model from vertexAI and googleAI

* tests(firestore-multimodal-genai): mock the googleAI and vertexAI model

* chore(firestore-multimodal-genai): run npm audit fix

* fix(firestore-multimodal-genai): fix tests

---------

Co-authored-by: Jacob Cable <jacobcable94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firestore-multimodal-genai]: Add support for Gemini 2.5 model

4 participants