Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Gemini 2.5 models to the firestore-multimodal-genai extension while removing deprecated Gemini models. The implementation updates both GoogleAI and VertexAI providers to include the new Gemini 2.5 model variants.
- Adds support for three new Gemini 2.5 models: FlashPreview0417, ProExp0325, and ProPreview0325
- Removes deprecated Gemini models including older experimental and preview versions
- Updates package dependencies to support the new models and removes outdated test configurations
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| functions/src/generative-client/genkit.ts | Updates model imports and references to add Gemini 2.5 models and remove deprecated ones |
| functions/package.json | Upgrades genkit-ai dependencies from v1.3.0/v1.9.0 to v1.14.1 |
| functions/tests/vertex_ai/index.test.ts | Updates test configuration to use gemini-2.5-pro instead of gemini-1.0-pro |
| functions/tests/vertex_ai/images.test.ts | Updates test configuration to use gemini-2.5-pro instead of gemini-1.0-pro |
| functions/tests/google_ai/index.test.ts | Updates test configuration to use gemini-2.5-pro instead of gemini-1.0-pro |
| functions/tests/google_ai/images.test.ts | Updates test configuration to use gemini-2.5-pro instead of gemini-1.0-pro |
| functions/tests/genkit/client.test.ts | Updates mock configurations to use gemini-2.5-pro instead of gemini-1.0-pro |
| extension.yaml | Bumps extension version from 1.0.4 to 1.0.5 |
| CHANGELOG.md | Documents the addition of Gemini 2.5 support and removal of deprecated models |
Files not reviewed (1)
- firestore-multimodal-genai/functions/package-lock.json: Language not supported
Comments suppressed due to low confidence (2)
firestore-multimodal-genai/functions/tests/genkit/client.test.ts:27
- The test mocks are using 'gemini25Pro' but the actual code imports 'gemini25FlashPreview0417', 'gemini25ProExp0325', and 'gemini25ProPreview0325'. The mock should reflect the actual model variants being used in the implementation.
gemini25Pro: {name: 'googleai/gemini-2.5-pro', withVersion: jest.fn()},
firestore-multimodal-genai/functions/tests/genkit/client.test.ts:34
- The test mocks are using 'gemini25Pro' but the actual code imports 'gemini25FlashPreview0417', 'gemini25ProExp0325', and 'gemini25ProPreview0325'. The mock should reflect the actual model variants being used in the implementation.
gemini25Pro: {name: 'vertexai/gemini-2.5-pro', withVersion: jest.fn()},
cabljac
requested changes
Jul 18, 2025
Collaborator
cabljac
left a comment
There was a problem hiding this comment.
- Can we double check the update to README to make sure it's accurate to what we're doing?
- Can we add a note to the model param in the extension.yaml to let people know about deprecation/retiring of models
CorieW
requested changes
Jul 21, 2025
firestore-multimodal-genai/functions/src/generative-client/genkit.ts
Outdated
Show resolved
Hide resolved
firestore-multimodal-genai/functions/src/generative-client/genkit.ts
Outdated
Show resolved
Hide resolved
firestore-multimodal-genai/functions/src/generative-client/genkit.ts
Outdated
Show resolved
Hide resolved
firestore-multimodal-genai/functions/src/generative-client/genkit.ts
Outdated
Show resolved
Hide resolved
87c7948 to
d7ede90
Compare
… from vertexAI and googleAI
9637fe3 to
a210468
Compare
CorieW
approved these changes
Jul 22, 2025
andyma-star
pushed a commit
to andyma-star/firebase-extensions
that referenced
this pull request
Mar 12, 2026
…oogleCloudPlatform#724) * feat(firestore-multimodal-genai): feat: Add support for Gemini 2.5 models * chore(firestore-multimodal-genai): remove gemini20ProExp0205 * chore(firestore-multimodal-genai): remove deprecated models * test(firestore-multimodal-genai): swap gemini-1.0-pro => gemini-2.5-pro * test(firestore-multimodal-genai): remove deprecated gemini-1.0-pro * docs(firestore-multimodal-genai): update changelog * refactor(firestore-multimodal-genai): correctly call gemini-2.5-model from vertexAI and googleAI * tests(firestore-multimodal-genai): mock the googleAI and vertexAI model * chore(firestore-multimodal-genai): run npm audit fix * fix(firestore-multimodal-genai): fix tests --------- Co-authored-by: Jacob Cable <jacobcable94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #717