feat(dataset): revise dataset generation skill#58
Merged
helloeve merged 4 commits intoGoogleCloudPlatform:feat/hill-climbingfrom Apr 1, 2026
Merged
feat(dataset): revise dataset generation skill#58helloeve merged 4 commits intoGoogleCloudPlatform:feat/hill-climbingfrom
helloeve merged 4 commits intoGoogleCloudPlatform:feat/hill-climbingfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new command configuration for generating and expanding NLQ-SQL datasets and updates the documentation for the dataset generation skill. Key changes include refining the workflow to utilize tools.yaml for database selection, updating tool naming conventions to use source-specific prefixes, and adjusting the standard evaluation JSON format to be a list of objects with placeholders. I have no feedback to provide.
helloeve
force-pushed
the
feat/fix-dataset
branch
from
4ff21cd to
f07582a
Compare
wangauone
approved these changes
Mar 31, 2026
wangauone
approved these changes
Apr 1, 2026
helloeve
merged commit 0f303f0
into
GoogleCloudPlatform:feat/hill-climbing
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.