Skip to content

site: use quicklink from dist and switch to npm workspaces - #465

Draft
XhmikosR wants to merge 3 commits into
mainfrom
xmr/site-bundle
Draft

site: use quicklink from dist and switch to npm workspaces#465
XhmikosR wants to merge 3 commits into
mainfrom
xmr/site-bundle

Conversation

@XhmikosR

@XhmikosR XhmikosR commented Dec 6, 2025

Copy link
Copy Markdown
Collaborator

Closes #389

TODO:

  • Adapt Netlify after merging this so that we don't run double builds
  • Watch doesn't trigger if dist changes

Preview: https://deploy-preview-465--google-chrome-labs-quicklink.netlify.app/

@XhmikosR
XhmikosR force-pushed the xmr/site-bundle branch 5 times, most recently from e675811 to 42538f9 Compare December 7, 2025 08:40
@XhmikosR XhmikosR added the squash Squash PR label Dec 8, 2025
@XhmikosR
XhmikosR force-pushed the xmr/site-bundle branch 2 times, most recently from 31f633d to f353b01 Compare May 21, 2026 10:41
@XhmikosR
XhmikosR marked this pull request as ready for review May 21, 2026 10:42
@XhmikosR
XhmikosR requested a review from addyosmani May 21, 2026 10:42
@XhmikosR
XhmikosR marked this pull request as draft June 11, 2026 13:17
@XhmikosR
XhmikosR force-pushed the xmr/site-bundle branch 5 times, most recently from 9c33429 to afcf09d Compare June 16, 2026 07:55
@XhmikosR
XhmikosR force-pushed the xmr/site-bundle branch 3 times, most recently from 1a25782 to 647837d Compare July 26, 2026 12:11
@addyosmani

Copy link
Copy Markdown
Collaborator

Now that #463 landed, this'll want a rebase on top of the new rollup build. Looks like the only open item on your list is the Netlify double-build — happy to sort that on the Netlify side once this is ready. Flip it out of draft whenever and I'll review promptly. 👍

@XhmikosR
XhmikosR force-pushed the xmr/site-bundle branch 2 times, most recently from 2917aba to 03de721 Compare August 4, 2026 14:48
@XhmikosR

XhmikosR commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

I rebased it. It needs further testing. I couldn't find another way to make things work, so do let me know how it works for you or if you have any other ideas.

@XhmikosR

XhmikosR commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

Actually, let's put this on hold and look at my other PRs first. This needs some work. I'll drop clipboard since nowadays browsers have native support.

@addyosmani

Copy link
Copy Markdown
Collaborator

Heads-up that the hosting moved under this PR: getquick.link is now served from Netlify (the old Firebase project became inaccessible, so I migrated it). That makes your "adapt Netlify so we don't run double builds" TODO the real blocker here rather than a nice-to-have — once the site consumes quicklink from dist via the workspace, we'll want the Netlify build to run the workspace build once and publish site/build. The dist-over-CDN direction is right regardless; it drops the runtime dependency on jsDelivr and on whatever version happens to be published. Ping me when you flip it out of draft and I'll wire up the Netlify build command / a deploy action.

@XhmikosR

XhmikosR commented Aug 5, 2026 via email

Copy link
Copy Markdown
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squash Squash PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

site: use the files from dist folder instead of the CDN

2 participants