site: use quicklink from dist and switch to npm workspaces - #465
site: use quicklink from dist and switch to npm workspaces#465XhmikosR wants to merge 3 commits into
Conversation
e675811 to
42538f9
Compare
dfbf1be to
449db8e
Compare
31f633d to
f353b01
Compare
9c33429 to
afcf09d
Compare
1a25782 to
647837d
Compare
647837d to
c39093e
Compare
|
Now that #463 landed, this'll want a rebase on top of the new rollup build. Looks like the only open item on your list is the Netlify double-build — happy to sort that on the Netlify side once this is ready. Flip it out of draft whenever and I'll review promptly. 👍 |
2917aba to
03de721
Compare
|
I rebased it. It needs further testing. I couldn't find another way to make things work, so do let me know how it works for you or if you have any other ideas. |
|
Actually, let's put this on hold and look at my other PRs first. This needs some work. I'll drop clipboard since nowadays browsers have native support. |
|
Heads-up that the hosting moved under this PR: getquick.link is now served from Netlify (the old Firebase project became inaccessible, so I migrated it). That makes your "adapt Netlify so we don't run double builds" TODO the real blocker here rather than a nice-to-have — once the site consumes quicklink from |
|
Can you add me as an administrator on Netlify so that i set thibgs up?
Previously, we were using my account for previews.
…On Wed, Aug 5, 2026, 09:21 Addy Osmani ***@***.***> wrote:
*addyosmani* left a comment (GoogleChromeLabs/quicklink#465)
<#465 (comment)>
Heads-up that the hosting moved under this PR: getquick.link is now served
from Netlify (the old Firebase project became inaccessible, so I migrated
it). That makes your "adapt Netlify so we don't run double builds" TODO the
real blocker here rather than a nice-to-have — once the site consumes
quicklink from dist via the workspace, we'll want the Netlify build to
run the workspace build once and publish site/build. The dist-over-CDN
direction is right regardless; it drops the runtime dependency on jsDelivr
and on whatever version happens to be published. Ping me when you flip it
out of draft and I'll wire up the Netlify build command / a deploy action.
—
Reply to this email directly, view it on GitHub
<#465?email_source=notifications&email_token=AACVLNM4C3A4GFOFJ6ENDO35ILG65A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJYHAZTAMRUHEYKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5188302490>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNIIMWTQOWYUUJMMLRT5ILG65AVCNFSNUABFKJSXA33TNF2G64TZHMYTKOBYG4ZTSNRZHNEXG43VMU5TGNZQGE4TMMBUHE3KC5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
03de721 to
3bf10a3
Compare
Closes #389
TODO:
Preview: https://deploy-preview-465--google-chrome-labs-quicklink.netlify.app/