Skip to content

Removed infinite loop in parser.rdp.virtual_channel.dynamic_channel #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Res260 merged 1 commit into from
Jul 12, 2025
Merged

Removed infinite loop in parser.rdp.virtual_channel.dynamic_channel #494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pyrdp/parser/rdp/virtual_channel/dynamic_channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ def doParse(self, data: bytes) -> PDU:
channelName = ""
char = stream.read(1).decode()
while char != "\x00":
if len(char) == 0:
raise ValueError("Channel name is not null-terminated")
channelName += char
char = stream.read(1).decode()
return CreateRequestPDU(cbid, sp, channelId, channelName)
Expand Down
Loading