Try to get the environment syntax correct#49
Merged
kevinbackhouse merged 2 commits intoGitHubSecurityLab:mainfrom Nov 5, 2025
Merged
Try to get the environment syntax correct#49kevinbackhouse merged 2 commits intoGitHubSecurityLab:mainfrom
kevinbackhouse merged 2 commits intoGitHubSecurityLab:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the GitHub Actions workflow configuration to properly handle environment declarations in reusable workflows by moving the environment configuration from the caller's job level to the reusable workflow's job level and renaming the input parameter.
- Moved
environmentconfiguration from job level in the caller workflow to theusesworkflow input - Renamed the reusable workflow input from
environment(type: environment) toenvironment_name(type: string) - Updated the caller workflow to pass environment name as a string input instead of passing it as a structured object
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/publish-to-testpypi.yaml | Moved environment configuration from workflow input to job level and updated to pass environment name as string |
| .github/workflows/publish-reusable.yml | Changed input parameter from environment to environment_name with type string instead of environment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JarLob
previously approved these changes
Nov 5, 2025
JarLob
approved these changes
Nov 5, 2025
p-
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix these errors. I mistakenly thought that
environmentis a valid type forworkflow_call, but it turns out that I saw it in the documentation forworkflow_dispatch.