Merged
Conversation
nuest
requested changes
Feb 19, 2025
Member
nuest
left a comment
nuest
left a comment
There was a problem hiding this comment.
Looks good!
Please add a UI test and then this should be all done.
nuest
requested changes
Mar 19, 2025
| login(request, user, backend="django.contrib.auth.backends.ModelBackend") | ||
|
|
||
| return render(request,'changeuser.html') | ||
| messages.success(request, "Your email has been successfully updated!") |
Member
There was a problem hiding this comment.
Sorry, one more change here: Can you at the very end please also send one more message to the old email, so we also have a notification there: "Hi! Your email was changed from x to y, if that is incorrect please reach out to us at BASE_URL/contact.
switch to Chrome only
Member
|
@uxairibrar Unit tests are working again. |
nuest
approved these changes
Mar 27, 2025
Member
nuest
left a comment
nuest
left a comment
There was a problem hiding this comment.
Happy to merge this if @uxairibrar says it's complete - I think it is.
nuest
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #24