Send emails for new manuscripts for each subscription#90
Merged
Conversation
nuest
reviewed
Mar 19, 2025
Member
nuest
left a comment
There was a problem hiding this comment.
Not sure you already wanted input here, but I have a few minor comments.
Happy to merge soon, AFAICT only some tests are missing.
nuest
requested changes
Apr 4, 2025
Member
nuest
left a comment
There was a problem hiding this comment.
Looks all good, I'm only missing the tests.
Collaborator
Author
|
I have updated the tests |
Member
|
@uxairibrar Tests are failing. Please fix the unit tests. |
nuest
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71