Harvest data from online OJS instances at fixed interval#87
Conversation
nuest
left a comment
There was a problem hiding this comment.
I don't see any code related to Django-Q in this PR.
Could you please add a few illustrating screenshots how the interaction with the admin UI works? Thanks!
So, I wanted to automate this scheduling process, so I put adding scheduler on save in the models file. However, now I have also added a seperate admin action for it. |
|
@uxairibrar Tests are working again and branch is updated from main. |
nuest
left a comment
There was a problem hiding this comment.
All good - please just fix the failing tests: https://github.com/GeoinformationSystems/optimap/actions/runs/14266473472/job/39989399641?pr=87
nuest
left a comment
There was a problem hiding this comment.
I'll go ahead and merge - thanks for the efforts.
I do think though that we will have to improve the tests over time, as not all conditions are tested, for example:
- You check for "greater than zero" many publications, when you should know the exact number and test for that.
- You test only that the DOI starts with "10.", when you know the exact DOI. What if the regex if incorrect towards the end of the DOI?
Closes #47