fix: OSX toolchain and MoltenVK build fixes#109
Conversation
|
Get update from develop on ipfs-lite-cpp/libp2p develop, and make sure this compiles on SuperGenius/develop -> GeniusSDK/develop |
|
Also relative path to GSL would resolve to GeniusVentures/GSL fork, I don't know what you mean by breaks fresh clones, I have never had an issue cloning. |
57c617b to
2f06915
Compare
- Propagate CMAKE_MAKE_PROGRAM and CMAKE_OSX_* vars to subprojects in CommonCompilerOptions.CMake - Fix malformed xcodebuild command in MoltenVK build.sh (missing closing quote, ONLY_ACTIVE_ARCH tangled into wrong argument) - Make CMAKE_DEVELOPER_ROOT resolution non-fatal for Command Line Tools-only setups (no full Xcode) Built and verified on macOS with Command Line Tools.
2f06915 to
8233c6f
Compare
|
You're right about the GSL URL GSL.git resolves correctly to GeniusVentures/GSL. I've removed that change from the PR. The remaining three changes are real issues I hit:
I'll pull the latest from develop on ipfs-lite-cpp/libp2p and verify it compiles through SuperGenius/develop → GeniusSDK/develop. |
|
Hi @itsafuu ,Thanks for the feedback. I did a full verification of the build across the macOS toolchain and found that the remaining changes address real build-breaking issues rather than optional improvements. Summary of required fixes:
All of the above were reproducible build failures on macOS (Xcode 26.x / Clang 15+). After applying these fixes, I was able to complete a clean build of SuperGenius → GeniusSDK successfully. If you have time, could you please take a look and let me know if this approach is fine? |
|
|
Thanks, that makes sense. For the target issue, I’ll update the SDK to link directly against I’ll also recheck the I’ll split the fixes into the appropriate repos/PRs and update accordingly. |
613d4d8 to
ab36360
Compare
Summary
Built and verified on macOS with Command Line Tools. MoltenVK xcodebuild command now runs correctly for both Debug and Release variants.