Bring crdt backup, config, and network config logic from 3.5 branch.#308
Open
itsafuu wants to merge 16 commits into
Open
Bring crdt backup, config, and network config logic from 3.5 branch.#308itsafuu wants to merge 16 commits into
itsafuu wants to merge 16 commits into
Conversation
henriqueaklein
requested changes
Jun 3, 2026
henriqueaklein
left a comment
henriqueaklein
left a comment
Contributor
There was a problem hiding this comment.
io_threads_ is probably the only error. The rest are suggestions/improvements.
…pers. Shutdown processes
…should now be controlled by the network config json file
… same in 2 classes
henriqueaklein
requested changes
Jun 8, 2026
henriqueaklein
left a comment
henriqueaklein
left a comment
Contributor
There was a problem hiding this comment.
Check the duplicated code (probably result of merge errors) and more importantly, the crdt_datastore destructor needs the code that detects if the destructor was called by a worker thread, otherwise it will get stuck
…ackground mode so may want it back later
henriqueaklein
approved these changes
Jun 9, 2026
Super-Genius
added a commit
that referenced
this pull request
Jun 9, 2026
- 8 new auto-filed test-failure bugs (#300-#307) - 3 open PRs: #309 bridge_phase5, #308 crdt-3.5-backport, #299 memory-secure-storage - Updated bridge, consensus perf, and stale-item sections - Gate violations noted: no PR/issue templates exist in repo Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
EduMenges
force-pushed
the
develop
branch
3 times, most recently
from
128165d to
afb4967
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.