fix: asm() using the incorrect assembler for amd64 architecture#2558
fix: asm() using the incorrect assembler for amd64 architecture#2558CuB3y0nd wants to merge 3 commits intoGallopsled:devfrom
Conversation
|
Thanks! Now I think I did not say it clearly: we want every architrcture to follow this pattern. For example, assembling aarch64 should first try It should also be based on existing which_binutils function. My globs were supposed to be just illustrative, but the code should be kind of like the following: aliases = {
'aarch64': ['arm', 'something-exotic'],
'amd64': ['i386', 'whatever'],
...
}
try(target)
if hostmachine == target: try(native)
for alias in aliases[target]:
try(alias)So just like it used to be, but native moved between the first try and the rest of them, instead of current buggy implementation (native is currently considered last). |
|
Can you apply the changes you have in mind here please @Arusekk? |
|
Thank you for your contribution, but as discussed, the fix implemented in this PR doesn't solve the whole problem. I've tried to fix it myself in #2669. |
Changed the priority of assembler usage in amd64