CI : Update to Cortex 10.6.6.0#6983
Open
johnhaddon wants to merge 6 commits into
Open
Conversation
And remove unused imports.
- Test for duplicates at the file rather than directory level. This copes with situations where one search path is nested inside another. - Call `resolve()` so that if two different search paths refer to the same directory (perhaps by symlinks), we don't process them both.
TODO : YOU NEED TO ACTUALLY DO THIS!
It can't be relied upon for shaders loaded from USD, and we are trying to phase out its usage entirely.
Contributor
|
Changes look good to me. I've pushed a pair of fixups to update to the newly released Cortex 10.6.6.0 and update the expected warning message in ShadingEngineTest.testWarningForInvalidShaders. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cortex 10.6.6.0 doesn't actually exist yet, but it will when ImageEngine/cortex#1540 gets merged. This PR contains the necessary changes to adapt Gaffer for the new IECOREUSD_WRITE_CONFORMANT_OSL_SHADERS option it provides.