Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.

icysapphire's Fix for people appearing appearing on top of each other#282

Open
pisanvs wants to merge 31 commits intoFugiTech:masterfrom
icysapphire:master
Open

icysapphire's Fix for people appearing appearing on top of each other#282
pisanvs wants to merge 31 commits intoFugiTech:masterfrom
icysapphire:master

Conversation

@pisanvs
Copy link
Copy Markdown

@pisanvs pisanvs commented Jul 15, 2020

By submitting this Contribution you hereby grant to Chris Gamble a worldwide, royalty-free, non-exclusive, perpetual and irrevocable license, with the right to transfer an unlimited number of non-exclusive licenses or to grant sublicenses to third parties, under the Copyright covering the Contribution to use the Contribution by all means, including, but not limited to: publish the Contribution, modify the Contribution, prepare derivative works based upon or containing the Contribution and/or to combine the Contribution with other Materials, reproduce the Contribution in original or modified form, distribute, to make the Contribution available to the public, display and publicly perform the Contribution in original or modified form.

note: Everything here was made/fixed by icysapphire, not by me.

Comment thread extension/manifest.json
"author": "Chris Gamble",
"homepage_url": "https://github.com/Fugiman/google-meet-grid-view",
"version": "1.39.0",
"author": "Simone Marullo",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the manifest file should probably be pulled out before merging.

Copy link
Copy Markdown

@ajsirota ajsirota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The funding info should probably be changed before this gets merged.

@ajsirota
Copy link
Copy Markdown

ajsirota commented Sep 9, 2020

And also, the menu no longer works.
image
When I hover over the icon, the menu still appears at the usual place, making it unusable.

@buenoudg
Copy link
Copy Markdown

buenoudg commented Sep 9, 2020

And also, the menu no longer works.

Using @icysapphire's fix in Firefox, I also have the button in the wrong place, but the menu works as always.

buenoudg and others added 4 commits September 11, 2020 19:59
Two new strings were added in version 1.40: 'Current release' and 'Original release here (discontinued)'

This changes them to localized strings, with versions in English, Spanish, and Catalan
Some localizations (en, es, ca) for new strings
Some spanish localization fixes
@apalumbo
Copy link
Copy Markdown

apalumbo commented Dec 3, 2020

@icysapphire would you mind to change the manifest stuff so that the PR could be merged?

Copy link
Copy Markdown
Author

@pisanvs pisanvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add this...
edit: Didn't notice I'm reusing this PR

@Jkarhani
Copy link
Copy Markdown

The grid is no longer working well, all the people pictures are stuck above others..Any help please?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants