You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Closes#7703. Generic parameters in ABI declarations were either accepted without a useful diagnostic or produced confusing downstream errors when the ABI was implemented.
Fix
Detect generic parameters while converting ABI function declarations.
Emit a dedicated Generic parameters are not supported in ABI declarations. diagnostic at the generic parameter span.
Add an end-to-end compile-fail fixture covering the unsupported syntax.
Low Risk
Early diagnostic-only change in ABI declaration lowering; no runtime or contract-call behavior changes.
Overview ABI method signatures with type parameters (e.g. fn fun<T>()) are now rejected during ABI parse-tree conversion instead of slipping through or failing later with unclear errors.
When fn_signature.generics is present on an ABI interface fn, the compiler emits Generic parameters are not supported in ABI declarations. at the generic parameter span via new CompileError::GenericParametersNotSupportedInAbi, wired into the error span mapping like other ABI restrictions.
An e2e should_fail fixture (generic_parameters_in_abi) asserts the diagnostic on fn fun<T>() -> bool;.
Reviewed by Cursor Bugbot for commit 3887566. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #7703. Generic parameters in ABI declarations were either accepted without a useful diagnostic or produced confusing downstream errors when the ABI was implemented.
Fix
Generic parameters are not supported in ABI declarations.diagnostic at the generic parameter span.Validation
cargo test -p sway-core --lib(20 passed).