fsgs/amiga/roms.py: Add KickRom SHA1 sums from German A500 and A4000#55
Open
Yamakuzure wants to merge 2 commits intoFrodeSolheim:fs-uae-launcher-4-discontinuedfrom
Open
fsgs/amiga/roms.py: Add KickRom SHA1 sums from German A500 and A4000#55Yamakuzure wants to merge 2 commits intoFrodeSolheim:fs-uae-launcher-4-discontinuedfrom
Yamakuzure wants to merge 2 commits intoFrodeSolheim:fs-uae-launcher-4-discontinuedfrom
Conversation
Before my old Amiga computers died, I ripped the ROMs from them. Unfortunately the machines sold here in Germany seem to have been equipped with older Kick Rom versions then in other parts of the world. To use both ROMs without any issues (I do not have any other ROM files), I've added them to the roms.py file.
Owner
|
I cannot accept the pull request currently, because the launcher right assumes that it will use specific kickstart versions for each model, to make sure that games from the online game database work correctly, and also for netplay. I definitively see the problem though, and it should be possible to select and use non-standard ROM files in an easier manner (right now you must select them manually on a per-configuration basis). I might have to think about this and find a better way to solve this use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before my old Amiga computers died, I ripped the ROMs from them.
Unfortunately the machines sold here in Germany seem to have been
equipped with older Kick Rom versions then in other parts of the
world.
To use both ROMs without any issues (I do not have any other ROM
files), I've added them to the roms.py file.