Update to latest version of puff 2.3 to resolve decompression failures#34
Open
mitchellwaite wants to merge 1 commit intoFree60Project:masterfrom
Open
Update to latest version of puff 2.3 to resolve decompression failures#34mitchellwaite wants to merge 1 commit intoFree60Project:masterfrom
mitchellwaite wants to merge 1 commit intoFree60Project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm really not sure how I've run in to this all of a sudden, but as soon as I commit code changes to XeLL, lv1 starts hitting decompression failures. It's somehow related to the contents of the auto-generated version.h, since if I blank out the GITREV line the issue goes away.
In any case, I noticed that there was an updated version of the puff decompression library that has a few bug fixes. The issue I was running in to is resolved with the puff update.
Source: https://github.com/madler/zlib/blob/master/contrib/puff/puff.c