Move to Electron 41, replace Electron clipboard API with navigator.clipboard

[bengotow]

Summary

Migrated all clipboard operations from the deprecated Electron clipboard module to the standard Web API navigator.clipboard. This modernizes the codebase and aligns with current best practices for clipboard access in Electron applications.

Key Changes

• Removed clipboard imports from all Electron module requires across 8 files
• Replaced all clipboard.writeText() calls with navigator.clipboard.writeText() in:
  • evented-iframe.tsx (3 occurrences)
  • oauth-signin-page.tsx
  • participants-text-field.tsx
  • share-button.tsx
  • event-attendees-input.tsx
  • message-controls.tsx
  • copy-button.tsx
  • thread-list-context-menu.ts
  • thread-sharing-button.tsx

Implementation Details

• The navigator.clipboard API is the modern standard for clipboard access in web contexts and is available in Electron's renderer process
• All clipboard write operations are now using the same API, providing consistency across the codebase
• No functional changes to clipboard behavior; this is purely an API migration
• Electron version updated from 39.2.7 to 41.0.2 to ensure compatibility with the standard clipboard API

https://claude.ai/code/session_01WBGx8XkrU7X1FhuXGdMygt

[indent-staging]

Issues

No issues found.

Resolved (2 issues)

• navigator.clipboard.writeText() returns a Promise, but all 9 call sites use it fire-and-forget without await or .catch(). If the write fails (e.g., due to document focus loss in context menu callbacks), the user gets no feedback and an unhandled promise rejection is logged. In copy-button.tsx, the UI shows "Copied" immediately regardless of whether the write succeeded. (fixed by commit cfe0c47)
• The test harness in app/spec/spec-runner/master-before-each.ts (lines 130-136) still spies on electron.clipboard.writeText and readText, but production code no longer uses the Electron clipboard for writes. These spies are now dead code. (fixed by commit cfe0c47)

Summary

This PR upgrades Electron from 39.2.7 to 41.0.2 and migrates all renderer-process clipboard.writeText() calls from Electron's clipboard API to the standard Web navigator.clipboard.writeText() API, addressing a deprecation introduced in Electron 40. Platform-specific clipboard reads in composer-editor.tsx and main-process clipboard usage in application.ts are correctly preserved.

• Bump electron from 39.2.7 to 41.0.2 in package.json and regenerate package-lock.json
• Replace clipboard.writeText() (from electron) with navigator.clipboard.writeText() across 9 renderer-side files
• Add .catch() error handling on all async clipboard writes; copy-button.tsx awaits success before showing "Copied" label
• Update test spies in master-before-each.ts to mock navigator.clipboard instead of electron.clipboard
• Retain Electron clipboard API for platform-specific format reads (composer-editor.tsx) and main-process usage (application.ts)

CI Checks

better-sqlite3 fails to compile against Electron 41's Node/V8 headers during npm ci. The native module uses V8 APIs (PropertyCallbackInfo::This(), External::Value()) that have been changed/deprecated in the V8 version bundled with Electron 41 (Node ABI v145). The better-sqlite3 dependency needs to be upgraded to a version compatible with Electron 41's V8, or Electron should be pinned to a version that better-sqlite3 supports.

test •

better-sqlite3 native module fails to compile against Electron 41's V8 headers. The V8 API has breaking changes (PropertyCallbackInfo::This() removed, External::Value()/External::New() deprecated) that the current version of better-sqlite3 doesn't handle. Need to upgrade better-sqlite3 to a version compatible with Electron 41, or use electron-rebuild with the correct Electron version.

Rule Checks 3 rules evaluated, 3 passed, 0 failed

Passing rules

This is a longer title to see what happens when they are too long to fit
B
Ben Rule