[RFC] Add OSAL_posix (mostly ported from glib)#1718
Open
neoharp-dev wants to merge 1 commit intoFluidSynth:masterfrom
Open
[RFC] Add OSAL_posix (mostly ported from glib)#1718neoharp-dev wants to merge 1 commit intoFluidSynth:masterfrom
neoharp-dev wants to merge 1 commit intoFluidSynth:masterfrom
Conversation
derselbst
reviewed
Dec 14, 2025
Member
derselbst
left a comment
There was a problem hiding this comment.
Thanks for this enormous work! I am not yet sure, if I want to merge this though. For me, the underlying use-case (solving performance issues on Android) is too specific. I'd keep this open a bit as an RFC allowing others to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glib is a heavy dependency
cpp11 have performance issues on Android
So I yanked futex code from glib. Posix threads and sync primitives are used if futexes are not available.
It is used in our app, and works in both Android and iOS (although currently iOS app is still in testing), perforamce issues we had previously with cpp11 were not observed with OSAL_posix.