Skip to content

fix: use bg-body on sign-up card for dark mode compatibility#6973

Open
talissoncosta wants to merge 1 commit intomainfrom
fix/signup-card-dark-mode-6803
Open

fix: use bg-body on sign-up card for dark mode compatibility#6973
talissoncosta wants to merge 1 commit intomainfrom
fix/signup-card-dark-mode-6803

Conversation

@talissoncosta
Copy link
Contributor

@talissoncosta talissoncosta commented Mar 17, 2026

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Closes #6803

The sign-up page card uses bg-white, which in dark mode results in invisible labels (white text on white background) and no visual separation between the card and the page.

The login card already uses bg-body (which adapts to the current theme). This PR aligns the sign-up card with the same pattern.

Screenshots

Sign-up page (dark mode)

Before After
image image

How did you test this code?

  1. Enable dark mode
  2. Log out and navigate to the sign-up page
  3. Verify labels (First Name, Last Name, etc.) are visible
  4. Verify SSO buttons are visible
  5. Switch to light mode and verify no regression

Replace hardcoded bg-white with bg-body on the sign-up page card so it
adapts to dark mode. The login card already uses bg-body; this aligns
the sign-up card with the same pattern.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@talissoncosta talissoncosta requested a review from a team as a code owner March 17, 2026 13:53
@talissoncosta talissoncosta requested review from kyle-ssg and removed request for a team March 17, 2026 13:53
@claude
Copy link

claude bot commented Mar 17, 2026

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link

vercel bot commented Mar 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Mar 17, 2026 1:55pm
flagsmith-frontend-staging Ready Ready Preview, Comment Mar 17, 2026 1:55pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Mar 17, 2026 1:55pm

Request Review

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Mar 17, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6973 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6973 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6973 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6973 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6973 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6973 Finished ✅ Results

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  28.4 seconds
commit  633c3bf
info  🔄 Run: #15322 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  53.6 seconds
commit  633c3bf
info  🔄 Run: #15322 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  35.4 seconds
commit  633c3bf
info  🔄 Run: #15322 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  35.2 seconds
commit  633c3bf
info  🔄 Run: #15322 (attempt 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSO login buttons are invisible in dark mode on the login page

1 participant