Merged
Conversation
Contributor
|
@VincentLanglet thanks for submitting this. The PR looks good to me. You'll need to rebase onto the main branch once #91 is merged and then we can get this merged in. |
Contributor
|
@VincentLanglet #91 was merged yesterday so you're good to rebase and fix the conflict, then we can get this merged. Thanks! |
Contributor
Author
|
Done @matthewelwell |
matthewelwell
approved these changes
Mar 28, 2025
Contributor
Author
|
Hi @matthewelwell I'm not sure why but the 4.5.1 release is not present on composer |
Contributor
|
@VincentLanglet one day I'll remember to bump the version in composer.json (or we'll eventually integrate release please into this repo!). Sorry, it should be there now (or very soon) - I've recreated the release after bumping the version in #92 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @matthewelwell
With PHP 8.4 we get deprecation like
I try to solve all of them.