Remove final on method BeanSerializer.serialize()#4483
Merged
cowtowncoder merged 2 commits intoFasterXML:2.18from Apr 19, 2024
Merged
Remove final on method BeanSerializer.serialize()#4483cowtowncoder merged 2 commits intoFasterXML:2.18from
final on method BeanSerializer.serialize()#4483cowtowncoder merged 2 commits intoFasterXML:2.18from
Conversation
…ty between this method and BeanDeserializer.deserialize allowing for proxies and subclassing to change serialization behavior
Member
|
Makes sense; happy to merge this. But one (and only) process thing we need is CLA before the first contributions. It's this: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and is usually easiest done by printing, filling & signing, scanning, emailing to As soon as I get it, will merge. Thank you for the PR, looking forward to merging! |
cowtowncoder
added
2.18
Member
|
CLA recived, will merge. |
cowtowncoder
approved these changes
Apr 19, 2024
cowtowncoder
changed the title
final on method BeanSerializer.serialize()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
BeanDeserializer.deserializeis not final. This allows for modification to the deserialization process generally via proxy or subclass, ex adding validation. The reverse is not allowed though asBeanSerializer.Serializeis final.I propose removing final from the method to allow for these two inverse functions to be exposed equally. Idea originally discussed in #4482