Skip to content

Fix RegionFile constructor argument order#4401

Open
0x000006 wants to merge 1 commit intoFabricMC:1.21.11from
0x000006:patch-1
Open

Fix RegionFile constructor argument order#4401
0x000006 wants to merge 1 commit intoFabricMC:1.21.11from
0x000006:patch-1

Conversation

@0x000006
Copy link
Copy Markdown
Contributor

@0x000006 0x000006 commented Feb 6, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@haykam821 haykam821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter swap is very sneaky:

public RegionFile(StorageKey storageKey, Path directory, Path path, boolean dsync) throws IOException {
	this(storageKey, directory, path, ChunkCompressionFormat.getCurrentFormat(), dsync);
}

public RegionFile(StorageKey storageKey, Path path, Path directory, ChunkCompressionFormat compressionFormat, boolean dsync) throws IOException {
	// ...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants