Skip to content

Rename PositionedSoundInstance#master methods to match UI sound category#4397

Merged
haykam821 merged 1 commit intoFabricMC:1.21.11from
Liam-Broome:issue/4213
Jan 5, 2026
Merged

Rename PositionedSoundInstance#master methods to match UI sound category#4397
haykam821 merged 1 commit intoFabricMC:1.21.11from
Liam-Broome:issue/4213

Conversation

@Liam-Broome
Copy link
Copy Markdown
Contributor

@Liam-Broome Liam-Broome commented Dec 31, 2025

Fixes #4213

Updated method names from 'master' to 'ui' in PositionedSoundInstance.mapping to improve clarity and reflect their usage. No functional changes were made.
@haykam821 haykam821 changed the title [Issue][4213] - Rename 'master' methods to 'ui' in sound mapping. Rename PositionedSoundInstance master methods to match UI sound category Jan 1, 2026
@haykam821 haykam821 added bug Fixes or discusses a bug within the mappings refactor A PR that renames existing names. release A PR that targets a release version of Minecraft labels Jan 1, 2026
@haykam821 haykam821 changed the title Rename PositionedSoundInstance master methods to match UI sound category Rename PositionedSoundInstance#master methods to match UI sound category Jan 5, 2026
@haykam821 haykam821 merged commit 3ce892a into FabricMC:1.21.11 Jan 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes or discusses a bug within the mappings refactor A PR that renames existing names. release A PR that targets a release version of Minecraft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PositionedSoundInstance#master methods use the UI sound category

2 participants