Open
Conversation
wistefan
requested changes
Mar 13, 2026
wistefan
requested changes
Mar 26, 2026
wistefan
requested changes
Apr 23, 2026
Collaborator
wistefan
left a comment
wistefan
left a comment
There was a problem hiding this comment.
It now mostly looks good, just the weird schemaLocation handling on the TMForumMapper needs to be explained/resolved.
| @Mapping(target = "atSchemaLocation", ignore = true) | ||
| public abstract DocumentSpecificationVO map(DocumentSpecificationCreateVO createVO, URI id); | ||
|
|
||
| @AfterMapping |
Collaborator
There was a problem hiding this comment.
Why is this back again? Whats the reason for this?
| public abstract DocumentSpecificationVO map(DocumentSpecification documentSpecification); | ||
|
|
||
| @Mapping(target = "href", source = "id") | ||
| @Mapping(target = "atSchemaLocation", ignore = true) |
Collaborator
There was a problem hiding this comment.
Why is atSchemaLocation ignored and than reapplied with an afterMapping?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings @wistefan
This is the Document API management feature. I also added the changes to add this to the all-in-one feature recently added.
Best regards