You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I didn't see any specific issues with this, but I'm a little concerned about how it's likely to conflict with changes to master. It looks like the last commit from master to be merged back into the mvp branch was bf1e957 in Feb 2019, and there have been 5 commits to master since then (including adding the package files via PR #151) that didn't get merged into mvp. It may be worth checking if the latest changes from master can be merged back into mvp and regenerating the package files to see if there are any differences specifically needed for the mvp branch. If not, this can just be closed, since the new files would have already been merged into mvp from master.
I can rebase against master. I wasn't 100% sure about the timeline of the branches - thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.