Skip to content

fix: add pnpm overrides for vulnerable deps, move serve to devDeps, add audit CI (closes #83) - #85

Open
LucasMaupin wants to merge 1 commit into
mainfrom
fix/issue-83-dependency-audit-overrides
Open

fix: add pnpm overrides for vulnerable deps, move serve to devDeps, add audit CI (closes #83)#85
LucasMaupin wants to merge 1 commit into
mainfrom
fix/issue-83-dependency-audit-overrides

Conversation

@LucasMaupin

Copy link
Copy Markdown
Collaborator

Summary

  • Adds pnpm.overrides to pin vulnerable transitive dependencies to safe versions:
    • vite>=6.4.3 (resolved to 8.1.5 — fixes fs.deny bypass and NTLMv2 hash disclosure)
    • postcss>=8.5.10 (fixes CVE-2026-41305 XSS via unescaped </style>)
    • fast-uri>=3.1.2 (fixes host confusion + path traversal)
    • brace-expansion>=5.0.6 (fixes ReDoS)
    • js-yaml>=4.2.0 (fixes quadratic-complexity DoS)
    • @babel/core>=7.29.6 (fixes arbitrary file read via sourceMappingURL)
  • Moves serve from dependenciesdevDependencies (it is not used in Docker/production nginx deployments)
  • Renames start script to start:local to make clear it is for local/dev use only; production deployments use the Docker image with nginx
  • Adds .github/workflows/audit.yml running pnpm audit --audit-level=high on every PR touching package.json/pnpm-lock.yaml, and on a weekly schedule

Test plan

  • Run pnpm install and verify locked versions satisfy all overrides
  • Run pnpm audit and confirm high-severity advisories are resolved
  • Verify pnpm build succeeds
  • Confirm serve is no longer in the production dependency set (pnpm list --prod | grep serve returns empty)
  • Verify the audit CI workflow triggers on a test PR changing package.json

Closes #83

🤖 Generated with Claude Code

…dd audit CI (closes #83)

- Add pnpm.overrides pinning vite>=6.4.3 (resolved 8.1.5), postcss>=8.5.10,
  fast-uri>=3.1.2, brace-expansion>=5.0.6, js-yaml>=4.2.0, @babel/core>=7.29.6
- Move `serve` from dependencies to devDependencies (it is not used in Docker/production)
- Rename `start` script to `start:local` to make its dev-only nature explicit;
  production deployments use the Docker image with nginx
- Add .github/workflows/audit.yml running `pnpm audit --audit-level=high` on
  every PR that touches package.json or pnpm-lock.yaml, and weekly on main

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SECURITY][MEDIUM] 12 vulnerable build/dev dependencies — vite path bypass, postcss XSS, serve used in production

1 participant