feat: Extend shift+click range selection to Search results and report transaction lists by TaduJR · Pull Request #98130 · Expensify/App

TaduJR · 2026-08-10T11:52:34Z

Explanation of Change

Shift+click now selects a range in the Search results for expenses and reports, and in the transaction list on a report. Click one row, hold Shift, click another, and everything between them is selected. It runs on the same shared logic that shipped in part 1, so it behaves the way it already does in the tables.

A few things worth knowing:

Group headers work as before. Clicking one selects or clears the whole group. If the group is open, a Shift+click after that narrows the selection to the rows you pick.
Select all followed by a Shift+click narrows the selection to the range you clicked. Rows in groups you have not opened yet have not loaded, so they stay selected.
In the Reports view, rows inside an expanded report still select one at a time. Only the report rows themselves take part in a range.

Fixed Issues

$ #90539
PROPOSAL: #90539 (comment)

Tests

Prerequisite: You need a workspace with at least 10 expenses across 3 or more categories, and at least 3 reports that each contain several expenses.

1. Expenses list

Go to Search/Spend, open the Expenses tab, and set Group by to none.
Click the checkbox on the 2nd expense. Verify only that expense is checked.
Hold Shift and click the checkbox on the 6th expense. Verify expenses 2 through 6 are all checked.
Hold Shift and click the 4th expense. Verify the selection shrinks to 2 through 4, and 5 and 6 are now unchecked.
Hold Shift and click the 8th expense. Verify expenses 2 through 8 are checked.
Clear the selection, click the checkbox at the top of the list to select everything, then hold Shift and click the 3rd expense. Verify only expenses 1 through 3 stay checked.

2. Grouped expenses

In the Expenses tab, set Group by to Category, then open the first two groups.
Click the checkbox on the first expense in group 1, then hold Shift and click an expense in group 2. Verify every expense between the two is checked, across both groups, and the group headers update to match.
Hold Shift and click an earlier expense in group 1. Verify the selection shrinks so only the expenses between your first click and this one stay checked.
Open group 3 and click its header checkbox. Verify every expense in that group is checked.
Hold Shift and click the 2nd expense in group 3. Verify only the first two expenses of that group stay checked.
Close group 2 and open it again straight away, before the closing animation finishes. Click an expense above it, then hold Shift and click an expense below it. Verify the expenses inside group 2 are checked along with the rest.

3. Reports tab

Go to Search/Spend and open the Reports tab.
Click the checkbox on report 2, then hold Shift and click report 5. Verify reports 2 through 5 are checked.
Clear the selection, then click the checkbox on report 6.
Open report 8 and click the checkbox on one expense inside it. Verify that expense is checked and report 6 is still checked.
Hold Shift and click report 9. Verify reports 6 through 9 are checked, and reports 1 through 5 are still unchecked.
Inside an open report, hold Shift and click a second expense. Verify expenses inside a report are still selected one at a time; Shift does not select a stretch of them.

4. Expenses on a report

Open a report that has at least 6 expenses.
Click the checkbox on the 2nd expense, then hold Shift and click the 5th. Verify expenses 2 through 5 are checked.
Hold Shift and click the 3rd expense. Verify the selection shrinks to 2 and 3.
Group the report's expenses by Category, click a group header checkbox, then hold Shift and click the 2nd expense in that group. Verify the whole group checks first, then the selection narrows to the first two expenses.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Mac-Chrome.mp4

…Report lists

melvin-bot · 2026-08-10T11:52:40Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-08-10T11:52:46Z

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-08-10T11:58:03Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...stReportView/MoneyRequestReportTransactionItem.tsx	`0.00% <ø> (ø)`
src/components/Search/SearchContext.tsx	`100.00% <100.00%> (ø)`
...rch/SearchList/ListItem/GroupChildrenContainer.tsx	`0.00% <ø> (ø)`
...h/SearchList/ListItem/TransactionGroupListItem.tsx	`77.08% <100.00%> (+0.50%)`	⬆️
src/components/Search/SearchList/ListItem/types.ts	`100.00% <ø> (ø)`
.../ListItem/useRegisterGroupChildrenForShiftRange.ts	`100.00% <100.00%> (ø)`
src/components/Search/SearchSelectionProvider.tsx	`74.28% <100.00%> (+1.01%)`	⬆️
src/components/Search/index.tsx	`49.65% <ø> (ø)`
src/hooks/useShiftRangeSelection.ts	`98.01% <100.00%> (+0.25%)`	⬆️
src/libs/SearchUIUtils.ts	`66.58% <100.00%> (+0.59%)`	⬆️
... and 13 more
... and 8 files with indirect coverage changes

…shift-range-search # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

TaduJR · 2026-08-10T12:17:43Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: adc86b1bf8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62141034fb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…ren loaded

…groups

TaduJR · 2026-08-10T17:27:02Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11cd7f08c1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

joekaufmanexpensify

Good for product

…shift-range-search # Conflicts: # src/components/Search/SearchList/ListItem/GroupChildrenContent.tsx # src/components/Search/SearchList/ListItem/TransactionGroupListItem.tsx

…shift-range-search # Conflicts: # src/components/Search/SearchList/ListItem/TransactionGroupListItem.tsx # src/components/Search/types.ts # tests/unit/Search/LazyGroupSelectionTest.tsx

TaduJR · 2026-08-12T06:54:49Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 46dcc486fe

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

TaduJR · 2026-08-12T07:32:44Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9fae8b20d3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-08-12T07:41:03Z

+                }
+                return updated;
+            },
+            {data: filteredData, totalSelectableItemsCount},


Preserve all-matching selection in range updates

When an expense search is in “Select all matching” mode and the user Shift+clicks to shrink a visible range, this range path calls applySelection without the same shouldPreserveAllMatchingSelection/exclusion options used by normal row toggles. As soon as the range deselects any loaded row, applySelection clears areAllMatchingItemsSelected and drops the off-page matching expenses instead of recording those visible rows as exclusions, so bulk actions unexpectedly stop applying to the full matching result set. Please pass the same preservation options used by the single-row expense toggle here.

Useful? React with 👍 / 👎.

feat: add shift+click range selection to the Reports and MoneyRequest…

1d3cdc4

…Report lists

TaduJR requested review from a team as code owners August 10, 2026 11:52

melvin-bot Bot assigned TaduJR Aug 10, 2026

melvin-bot Bot requested a review from situchan August 10, 2026 11:52

melvin-bot Bot requested review from a team, joekaufmanexpensify and stitesExpensify and removed request for a team August 10, 2026 11:52

TaduJR marked this pull request as draft August 10, 2026 11:53

github-actions Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx Outdated

github-actions Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread src/components/Search/selectionBuilders.ts Outdated

github-actions Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread src/components/Search/SearchList/ListItem/TransactionGroupListItem.tsx Outdated

github-actions Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread src/components/Search/SearchList/ListItem/useGroupChildrenForShiftRange.ts Outdated

github-actions Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread src/components/Search/SearchWriteActionsProvider.tsx

TaduJR added 2 commits August 10, 2026 15:16

chore: apply plain comment style

adc86b1

fix: rename isAnchorable to canAnchor

6214103

chatgpt-codex-connector Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread src/components/Search/SearchList/ListItem/useGroupChildrenForShiftRange.ts

TaduJR marked this pull request as ready for review August 10, 2026 12:58

chatgpt-codex-connector Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread src/components/Search/SearchList/ListItem/useGroupChildrenForShiftRange.ts Outdated

TaduJR added 2 commits August 10, 2026 16:25

fix: allow deselecting one child of a group selected before its child…

54ddf2e

…ren loaded

fix: share one group-selected check and stop layout flips collapsing …

11cd7f0

…groups

chatgpt-codex-connector Bot reviewed Aug 10, 2026

View reviewed changes

Comment thread src/components/Search/SearchWriteActionsProvider.tsx

TaduJR added 3 commits August 10, 2026 20:41

fix: let shift+click narrow a group selected before its children loaded

ab0262b

fix: split the engine's selected check into anchoring and protection

7df7370

fix: only unregister group children when leaving the split layout

e1f3103

joekaufmanexpensify previously approved these changes Aug 10, 2026

View reviewed changes

TaduJR added 11 commits August 11, 2026 10:48

fix: let a cold range adopt a block selection so it can narrow all of it

1395126

Merge branch 'main' of https://github.com/TaduJR/App into feat/90539-…

16622a6

…shift-range-search # Conflicts: # src/components/Search/SearchList/ListItem/GroupChildrenContent.tsx # src/components/Search/SearchList/ListItem/TransactionGroupListItem.tsx

refactor: build Search list test fixtures without type casts

9ce8f5d

fix: spell out a group selection before adding its children to a range

238f477

fix: refresh stale group children and keep paging groups whole

598ff51

fix: keep a closed group's rows out of shift+click ranges

153048c

Merge branch 'main' of https://github.com/TaduJR/App into feat/90539-…

e416726

…shift-range-search # Conflicts: # src/components/Search/SearchList/ListItem/TransactionGroupListItem.tsx # src/components/Search/types.ts # tests/unit/Search/LazyGroupSelectionTest.tsx

chore: drop comments that restate the code

1bd909a

chore: document the shift+click hook params and args

c4b407e

fix: seed a lazy group's range once its rows arrive

c6e054f

fix: treat a re-resolved anchor as a fresh session

46dcc48

TaduJR dismissed joekaufmanexpensify’s stale review via 46dcc48 August 12, 2026 06:54

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

Comment thread src/components/Search/SearchWriteActionsProvider.tsx Outdated

TaduJR added 2 commits August 12, 2026 10:20

fix: stop a header selection counting as hand-picked

bcf9d68

refactor: clear the pending seed in one place and drop an unused return

9fae8b2

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

TaduJR marked this pull request as draft August 12, 2026 11:25

Uh oh!

Conversation

TaduJR commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 10, 2026

Uh oh!

melvin-bot Bot commented Aug 10, 2026

Uh oh!

codecov Bot commented Aug 10, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TaduJR commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

TaduJR commented Aug 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

TaduJR commented Aug 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

TaduJR commented Aug 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TaduJR commented Aug 10, 2026 •

edited

Loading

codecov Bot commented Aug 10, 2026 •

edited by github-actions Bot

Loading