Show Concierge thread title - #98090
Conversation
|
@cretadn22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@gijoe0295 @puneetlath One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61d37b986c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Concierge titles each of its threads with a summary of the question, so show that rather than the question itself. | ||
| if (report.reportName && isConciergeChatReport(getReportOrDraftReport(report.parentReportID))) { | ||
| return report.reportName; |
There was a problem hiding this comment.
Apply redaction placeholders before Concierge titles
When a Concierge thread's parent question is deleted or hidden by moderation, this early return runs before the existing deletedMessage and hiddenMessage branches, so the generated summary remains visible in the LHN and header even though the underlying message is redacted. Check those redaction states before returning the stored Concierge title.
Useful? React with 👍 / 👎.
| } | ||
|
|
||
| // Concierge titles each of its threads with a summary of the question, so show that rather than the question itself. | ||
| if (report.reportName && isConciergeChatReport(getReportOrDraftReport(report.parentReportID))) { |
There was a problem hiding this comment.
Use the supplied report data to identify Concierge
When computeReportName is called with current reports and conciergeReportID—including from the report-attributes derived config—this lookup ignores both and instead reads the deprecated module-level Onyx caches through getReportOrDraftReport() and the default argument of isConciergeChatReport(). If those independent caches are not hydrated or are stale, the thread is misclassified and keeps showing the raw question; updating the cache alone does not retrigger this computation. Pass the already-supplied parent report and Concierge ID into this helper instead. CLAUDE.mdL160-L165
Useful? React with 👍 / 👎.
Explanation of Change
computeChatThreadReportNamederives a chat thread's name from its parent action's message, so a Concierge thread always displays the raw question. The backend now titles those threads with a short summary, which was being stored and never shown.This prefers
reportNamewhen the thread's parent is the Concierge DM. Every other chat thread is unchanged.Requires https://github.com/Expensify/Web-Expensify/pull/55236 and https://github.com/Expensify/Auth/pull/23595.
Fixed Issues
$ #94503
PROPOSAL:
Tests
conciergeRespondInThreadbeta and ask Concierge a question.Offline tests
QA Steps
conciergeRespondInThreadbeta and ask Concierge a question.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionScreenshots/Videos
MacOS: Chrome / Safari