Skip to content

Update system messages for expenses moved to different reports#80444

Open
twilight2294 wants to merge 4 commits intoExpensify:mainfrom
twilight2294:issue70485
Open

Update system messages for expenses moved to different reports#80444
twilight2294 wants to merge 4 commits intoExpensify:mainfrom
twilight2294:issue70485

Conversation

@twilight2294
Copy link
Contributor

@twilight2294 twilight2294 commented Jan 25, 2026 •
edited
Loading

Explanation of Change

Fixed Issues

$ #70485
PROPOSAL: #70485 (comment)

Tests

same as QA

  • Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

Test Case 1: No system message when moving expenses FROM a Draft report

  1. Create a new expense on a workspace (this creates a Draft/Open report)
  2. Before submitting the report, go to the expense and select "Move to..."
  3. Move the expense to a different report (either another existing Draft report or a new workspace)
  4. Open the expense thread/chat for the moved expense

Verify that There should be NO "Expense moved from [report]" system message in the expense thread

Test Case 2: System message SHOULD appear when moving expenses FROM a non-Draft report

  1. Create an expense on a workspace
  2. Submit the expense report (making it a Submitted/Processing report, not Draft)
  3. As an approver or if the report is returned, move an expense from this non-Draft report to another report
  4. Open the expense thread/chat for the moved expense

Verify that A system message SHOULD appear indicating the expense was moved from the previous report

Test Case 3: No system message when rejecting an expense

  1. Create an expense report with multiple expenses
  2. Submit the report for approval
  3. As an approver, reject one of the expenses (providing a rejection reason)
  4. The rejected expense should be moved to a new Draft report
  5. Open the expense thread/chat for the rejected expense

Verify That There should be a "Rejected this expense" system message with the rejection reason
Verify that There should be NO additional "Expense moved to [new report]" system message

Test Case 4: No system message when held expense is moved while others are approved

  1. Create an expense report with multiple expenses
  2. Put a hold on one of the expenses
  3. Submit the report for approval
  4. As an approver, approve the report (the held expense will be moved to a new Draft report)
  5. Open the expense thread/chat for the held expense that was moved

Verify that There should be NO "Expense moved" system message for the held expense

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-02-05.at.6.14.25.PM.mov

@twilight2294 twilight2294 changed the title Update system messages for expenses moved to different reports [HOLD BE] Update system messages for expenses moved to different reports Jan 25, 2026
@twilight2294 twilight2294 mentioned this pull request Jan 25, 2026
Open
@twilight2294 twilight2294 marked this pull request as ready for review February 2, 2026 21:09
@twilight2294 twilight2294 requested review from a team as code owners February 2, 2026 21:09
@melvin-bot melvin-bot bot requested a review from parasharrajat February 2, 2026 21:09
@melvin-bot
Copy link

melvin-bot bot commented Feb 2, 2026

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from JmillsExpensify and removed request for a team February 2, 2026 21:09
@twilight2294
Copy link
Contributor Author

twilight2294 commented Feb 2, 2026

@parasharrajat please begin your review, i'm having issue with emulator, i'll fix that and update the recordings and will ping you

@twilight2294 twilight2294 changed the title [HOLD BE] Update system messages for expenses moved to different reports Update system messages for expenses moved to different reports Feb 3, 2026
@twilight2294
Copy link
Contributor Author

twilight2294 commented Feb 4, 2026

bump for review @parasharrajat

@parasharrajat
Copy link
Member

parasharrajat commented Feb 4, 2026

Thanks for the bump... I will get on it soon.

@parasharrajat
Copy link
Member

parasharrajat commented Feb 4, 2026

You can start adding vids for platforms...

@twilight2294
Copy link
Contributor Author

twilight2294 commented Feb 5, 2026 •
edited
Loading

bump for review @parasharrajat , it would be better if the review can come in today / tomorrow so i can address the comments, thanks 😄

@twilight2294
Copy link
Contributor Author

twilight2294 commented Feb 5, 2026

I'm still working on videos, i should have them by tomorrow morning, i updated the Web video now. sorry for the delay on those ones i am having a lot of build errors

parasharrajat
parasharrajat reviewed Feb 7, 2026
View reviewed changes
src/libs/actions/Transaction.ts
Comment on lines +1280 to +1288
const buildMovedAction = () => {
if (isSourceReportDraft) {
return undefined;
}
if (reportID === CONST.REPORT.UNREPORTED_REPORT_ID) {
return buildOptimisticUnreportedTransactionAction(transactionThreadReportID, oldReportID);
}
return buildOptimisticMovedTransactionAction(transactionThreadReportID, oldReportID);
};
Copy link
Member

@parasharrajat parasharrajat Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also not create message for unreported expenses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JmillsExpensify JmillsExpensify Awaiting requested review from JmillsExpensify

1 more reviewer

@parasharrajat parasharrajat parasharrajat left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@twilight2294 twilight2294

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twilight2294 @parasharrajat