-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[Duplicate Expenses] Add Per Diem Expense Support #78792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Duplicate Expenses] Add Per Diem Expense Support #78792
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@JS00001 This is testing quite well now, but I'm getting an "unexpected error occurred" when duplicating from a non-default workspace. As far as I can tell all the necessary params are being passed, so it's a bit difficult to debug with a generic error like that 😄 Are you able to help track down what the actual error is on the BE? Request ID: |
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
JS00001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin good, will wait on @hoangzinh 's review
|
I missed that, let me look, sorry about that |
|
Looks like this is a BE issue with padding a custom unit that doesnt match the policy we are creating the expense in |
|
@jjcoffee Why do we not duplicate the distance expense to the same workspace? Why move it to the default? |
@JS00001 I don't know the underlying product reason, but that's the expected behaviour from the original issue (not specific to distance expenses), and is what happens on OD. From #65948:
|
@JS00001 Are there any semi-recent changes there? I could swear it worked before on the original PR, because I remember testing to make sure an invalid rate error would come up (the same way it does if moving a per diem to a different workspace) following the same process of duplicating from a non-default workspace. |
|
It looks like we've been throwing that for 13 months, I'm looking at changing this |
|
@jjcoffee Lets go with the same solution as Distance rates got. I'm going to update |
|
Tested the PR with a hard-coded customUnitPolicyID, and it works as expected, will get those BE prs reviewed now |
trjExpensify
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WN project, all good from me with adding support for this! 👍
Explanation of Change
Fixed Issues
$ #76829
PROPOSAL:
Tests
Same as QA.
Offline tests
Same as QA.
QA Steps
Pre-requisite
DuplicateoptionPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-app-2026-01-07_12.19.05.mp4
Android: mWeb Chrome
android-chrome-2026-01-07_12.22.13.mp4
iOS: Native
ios-app-2026-01-07_12.06.31.mp4
iOS: mWeb Safari
ios-safari-2026-01-07_12.08.51.mp4
MacOS: Chrome / Safari
Old expense
desktop-chrome-2026-01-07_11.28.14.mp4
Normal flow
desktop-chrome-2026-01-07_11.59.58.mp4