-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: Marked as paid system message does not appear offline #78765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-06.at.20.18.30.android.movAndroid: mWeb ChromeScreen.Recording.2026-01-06.at.20.16.02.android.c.moviOS: HybridAppScreen.Recording.2026-01-06.at.20.23.53.ios.moviOS: mWeb SafariScreen.Recording.2026-01-06.at.20.21.16.ios.s.movMacOS: Chrome / SafariScreen.Recording.2026-01-06.at.20.11.57.web.mov |
hoangzinh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@nkdengineer is this something you could fix in a new PR? https://github.com/Expensify/App/actions/runs/20753680403 |
|
@carlosmiceli I think it's the original issue. |
|
What do you mean? |
|
@carlosmiceli I mean the type check was failed from this issue. |
|
Sorry, I still don't follow, merging this PR caused those tests to fail, why shouldn't we get a new PR up to fix those? |
|
@carlosmiceli I tried to run test for tests/actions/IOUTest.ts on latest main branch and all tests are passed 🤔 |
|
oh it was fixed in this PR #78916 |
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.95-0 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.95-5 🚀
|
Explanation of Change
Fixed Issues
$ #78370
PROPOSAL: #78370 (comment)
Tests
Marked as paidsystem message appearsOffline tests
Same
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-02.at.07.14.46.mov
Android: mWeb Chrome
Screen.Recording.2026-01-02.at.07.18.54.mov
iOS: Native
Screen.Recording.2026-01-02.at.07.21.42.mov
iOS: mWeb Safari
Screen.Recording.2026-01-02.at.07.30.18.mov
MacOS: Chrome / Safari
Screen.Recording.2026-01-02.at.07.34.18.mov