Support sending custom global requests from the client - #759
Open
ChrisJr404 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers the client side of #417. Right now there's no way to send a global request with a non-standard name, so the
configrequest from that issue (and anything else outside the built-in forwarding/keepalive ones) isn't reachable.I added
Handle::send_global_request(name, data, want_reply)that follows the same pattern astcpip_forwardand friends: it pushes the request onto the wire and, whenwant_replyis set, correlates the SUCCESS/FAILURE reply back through a oneshot. On success you get the response-specific payload back (empty if the peer sent none), and a failure comes back asRequestDenied. Withwant_replyfalse it just sends and returnsOk(None).There's a round-trip test in client/test.rs against the test server, which replies with a failure for the unknown name.
I kept this to the client send path since that's what the issue asks for. Handling incoming custom requests could be a nice follow-up.