Contributions to 4.9+, including fix for ARG_MAX issue, read only environments compatibility for IP chekpoint and some tests#901
Conversation
…nfig_path from builder.
…d since isn't critical
…ange of permission on copied files.
…ipts, avoiding ARG_MAX argument list limits.
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
|
I have read the CLA Document and I hereby sign the CLA |
Some instances of RPC code had rvalue reference arguments but did not use std::forward wenn passing these arguments (or the other way around). This harmonizes arguments and parameter forwarding to always use rvalue ref and std::forward in pairs.
This commit makes it explicit which assignment operators and constructors are available on the object class. Furthermore the copy constructor and assignment operator make deep copies of the object. This prevents double free operations with the rpc_error class.
|
@turcofran We've so far merged two commits: The ARG_MAX fix and the catch for the checkpoint generation. We probably won't merge the chmod fix, because it's not portable enough. Still need to review the rest. |
|
Alright, we've gone through this PR. All the smaller changes will be part of the next UHD release. As for the user clocks, I don't think we need them and we are not planning to include them. I'll add an example of how custom clocks work without this new change and let you know offline. |
3 participants
Pull Request Details
Description
Contributions to 4.9+, including fix for ARG_MAX issue, read only environments compatibility for IP checkpoint and some tests. Providing also additional resources to include user clocks.
Related Issue
ARG_MAX issue when OOT sources list is too long.
Which devices/areas does this affect?
Bitstream generation for for X400, X300, N3xx and E320, and E31x.
Testing Done
Bitstreams built with custom RFNoC blocks for X410, X310, N320, etc.
Checklist
MPM compat, noc_shell, specific RFNoC block, ...)