Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThe pull request updates the README file to align with the new features of the EternalCombat plugin. The file now reflects the updated version number (from 1.21.1 to 1.21.4) and highlights the key aspects of EternalCombat 2.0, such as enhanced combat logging, configurable spawn protection, and customizable combat options. New sections detail plugin functionality, permissions, placeholders, and developer API instructions. Additionally, contributing guidelines and bug reporting instructions have been clarified. There are no changes to the exported or public entities. Assessment against linked issues
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (7)
README.md (7)
5-7: Alt Text for Badge Images:
The badge image links are a great visual touch. Consider adding descriptive alt text (e.g.,) to improve accessibility.
9-11: Alt Text for Additional Badges:
Similar to the previous images, please add alt text for these badges (e.g.,) to help with accessibility and SEO.
30-34: Alt Text for Combat Log GIF:
In the Combat Logging bullet, the GIF is an effective visual aid. Please add alt text (e.g.,) to support accessibility.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
33-33: Images should have alternate text (alt text)
null(MD045, no-alt-text)
35-39: Alt Text for Spawn Protection GIF:
The Spawn Protection section includes a useful GIF. Adding descriptive alt text (e.g.,) would enhance accessibility.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
38-38: Images should have alternate text (alt text)
null(MD045, no-alt-text)
90-90: Heading Punctuation Consistency:
Consider removing the trailing colon from the "#### 1. Add repository:" heading for a cleaner, more consistent look.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
90-90: Trailing punctuation in heading
Punctuation: ':'(MD026, no-trailing-punctuation)
111-111: Heading Punctuation Consistency:
For the "#### 2. Add dependency:" heading, consider removing the trailing colon to match the style used in other headings.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
111-111: Trailing punctuation in heading
Punctuation: ':'(MD026, no-trailing-punctuation)
137-144: Reporting Issues & Tone:
The Reporting Issues section effectively guides users on how to report bugs. Consider toning down the exclamation in the final call-to-action for a more balanced, professional tone.🧰 Tools
🪛 LanguageTool
[style] ~144-~144: Using many exclamation marks might seem excessive (in this case: 12 exclamation marks for a text that’s 5314 characters long)
Context: ...Combat 2.0 now and let the battles begin!(EN_EXCESSIVE_EXCLAMATION)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
assets/border.gifis excluded by!**/*.gifassets/combatlog.gifis excluded by!**/*.gif
📒 Files selected for processing (1)
README.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
README.md
[uncategorized] ~47-~47: When ‘blacklist-specific’ is used as a modifier, it is usually spelled with a hyphen.
Context: ... | Commands | Whitelist or blacklist specific commands in combat. | | D...
(SPECIFIC_HYPHEN)
[style] ~144-~144: Using many exclamation marks might seem excessive (in this case: 12 exclamation marks for a text that’s 5314 characters long)
Context: ...Combat 2.0 now and let the battles begin!
(EN_EXCESSIVE_EXCLAMATION)
🪛 markdownlint-cli2 (0.17.2)
README.md
33-33: Images should have alternate text (alt text)
null
(MD045, no-alt-text)
38-38: Images should have alternate text (alt text)
null
(MD045, no-alt-text)
90-90: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
111-111: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
🔇 Additional comments (11)
README.md (11)
16-24: Updated Compatibility & Requirements Info:
The updated "Information" section clearly communicates supported Minecraft versions and Java requirements. Nice and clear update!
25-29: Enhanced Feature Overview:
The "How Does EternalCombat Work?" section gives a solid overview of the plugin’s features. The description is engaging and informative.
40-54: Comprehensive Feature Table:
The table listing customizable combat options is well-organized and clear. Great job laying out the features!🧰 Tools
🪛 LanguageTool
[uncategorized] ~47-~47: When ‘blacklist-specific’ is used as a modifier, it is usually spelled with a hyphen.
Context: ... | Commands | Whitelist or blacklist specific commands in combat. | | D...(SPECIFIC_HYPHEN)
55-57: Engaging Call-to-Action:
The YouTube presentation link is a nice touch and encourages users to learn more. Everything looks good in this section.
58-69: Clear Permissions Details:
The permissions section is neatly formatted and clearly explains the available commands. Excellent work!
70-83: Well-Structured PlaceholderAPI Section:
The updated PlaceholderAPI section with its accompanying table is informative and easy to follow.
92-98: Gradle Repository Block Looks Good:
The provided Gradle repository configuration is clear and correct.
100-109: Maven Repository Block is Correct:
The Maven repository configuration is accurately formatted and clear.
112-118: Gradle Dependency Declaration:
The Gradle dependency snippet is concise and correct.
119-129: Maven Dependency Declaration:
The Maven dependency configuration is clear and correctly formatted.
131-136: Contributing Section Clarity:
The "Contributing" section is welcoming and clearly directs users to the guidelines. Great job!
| [](https://modrinth.com/plugin/eternalcombat) | ||
| [](https://hangar.papermc.io/EternalCodeTeam/eternalcombat) | ||
|
|
||
| [](https://www.patreon.com/eternalcode) |
There was a problem hiding this comment.
maybe add kofi as a way to support our organisation
3 participants
Fixes: #186