Closed
Conversation
gavinr-maps
requested changes
Mar 28, 2025
Contributor
gavinr-maps
left a comment
gavinr-maps
left a comment
There was a problem hiding this comment.
Thanks very much for the PR! It seems to work fine, but on the initial call to the /mapserver endpoint it seems like when using token it does add it:
But with the code in the PR, when using apikey parameter it's not included:
I think that should probably be consistent, so if you can please update the code to include it in that case too.
Contributor
Author
|
Thanks @gavinr-maps, updated to align how it's implemented here. |
Contributor
Author
|
closing in favor of a new PR without formatting changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1404 - adds an apikey property to L.esri.TiledMapLayer