Disregard stale DynamicMapLayer updates#1261
Open
davetapley wants to merge 1 commit intoEsri:masterfrom
Open
Conversation
Alleviates (1) by not updating layer with image for a set of params which have changed while request was in flight. (1) Esri#749
Contributor
|
Hi @davetapley, thank you for offering this change, we appreciate it! 👍 As a holistic, longer-term update, I'd like to see esri-leaflet's requests mechanisms be updated to support network requests that can be aborted/canceled, as folks have mentioned in #749. It is on our radar to evaluate and consider that more closely, as it would be a bit of an update that would likely lead to a major version release. I think for now we'll leave your proposed change parked here while we figure out next steps. |
|
Hello @jwasilgeo, We're having the same issue in our application. I hope the solution is progressing. It will be very important! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alleviates #749 by not updating layer with image for a set of params which have changed while request was in flight.
This isn't the most elegant solution; I'm very open to feedback 😁