build(react): output bundle to its own dist/ instead of SignallingWebServer/www/#874
Merged
mcottontensor merged 1 commit intoEpicGamesExt:masterfrom May 5, 2026
Conversation
…Server/www/ Both reference frontend implementations were writing to SignallingWebServer/www/ with `clean: true`, so a top-level `npm run build --ws` ran the TS impl first and then had its output wiped by the React impl that ran second. Wilbur was then served the React impl's minimal page (auto-connect, no UI overlay) instead of the TS reference frontend. Point the React webpack at a local dist/ directory so the two implementations no longer collide. WEBPACK_OUTPUT_PATH is honoured for symmetry with the TS impl, and the readme documents how to have Wilbur serve this bundle via --http_root.
|
Collaborator
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mcottontensor
added a commit
that referenced
this pull request
May 5, 2026
…Server/www/ (#874) (#878) Both reference frontend implementations were writing to SignallingWebServer/www/ with `clean: true`, so a top-level `npm run build --ws` ran the TS impl first and then had its output wiped by the React impl that ran second. Wilbur was then served the React impl's minimal page (auto-connect, no UI overlay) instead of the TS reference frontend. Point the React webpack at a local dist/ directory so the two implementations no longer collide. WEBPACK_OUTPUT_PATH is honoured for symmetry with the TS impl, and the readme documents how to have Wilbur serve this bundle via --http_root. (cherry picked from commit 1096245)
mcottontensor
added a commit
that referenced
this pull request
May 5, 2026
…Server/www/ (#874) (#879) Both reference frontend implementations were writing to SignallingWebServer/www/ with `clean: true`, so a top-level `npm run build --ws` ran the TS impl first and then had its output wiped by the React impl that ran second. Wilbur was then served the React impl's minimal page (auto-connect, no UI overlay) instead of the TS reference frontend. Point the React webpack at a local dist/ directory so the two implementations no longer collide. WEBPACK_OUTPUT_PATH is honoured for symmetry with the TS impl, and the readme documents how to have Wilbur serve this bundle via --http_root. (cherry picked from commit 1096245)
mcottontensor
added a commit
that referenced
this pull request
May 5, 2026
…Server/www/ (#874) (#880) Both reference frontend implementations were writing to SignallingWebServer/www/ with `clean: true`, so a top-level `npm run build --ws` ran the TS impl first and then had its output wiped by the React impl that ran second. Wilbur was then served the React impl's minimal page (auto-connect, no UI overlay) instead of the TS reference frontend. Point the React webpack at a local dist/ directory so the two implementations no longer collide. WEBPACK_OUTPUT_PATH is honoured for symmetry with the TS impl, and the readme documents how to have Wilbur serve this bundle via --http_root. (cherry picked from commit 1096245)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both reference frontend implementations were writing to
SignallingWebServer/www/withclean: true.npm run build --wswalks workspaces in declared order, so:Frontend/implementations/typescriptbuilds → writesplayer.html,player.js, all UI assets towww/.Frontend/implementations/reactbuilds →clean: truewipes everything the TS impl just wrote, then writes onlyindex.html/index.js.After that,
start.sh'ssetup_frontend()checksif [ ! -d www ](SignallingWebServer/platform_scripts/bash/common.sh:229), seeswww/exists, and skips its own rebuild. Wilbur ends up serving the React impl's minimal page — auto-connect, no overlay, white background — instead of the expected TS reference frontend with itsClick to startoverlay and settings UI.The fix points the React webpack output at a local
dist/directory. The two implementations no longer collide.WEBPACK_OUTPUT_PATHis honoured for symmetry with the TS impl, and the readme picks up a short note showing how to have Wilbur serve the React bundle via--http_root.Repro before / verification after:
Test plan
rm -rfthennpm run buildat root —www/ends up with TS impl, React lands in its owndist/npm run lint --workspace Frontend/implementations/react)start.shafter a root build serves the proper UIstart.sh --http_root=$(pwd)/Frontend/implementations/react/distserves the React impl