[UE5.8] fix(signalling): do not crash when a forced subscription is declined (#958) - #969
Merged
Merged
Conversation
…958) * fix(signalling): do not crash when a forced subscription is declined sendToStreamer() force-subscribes a player that sends a message while unsubscribed, then forwards the message through non-null assertions on subscribedStreamer. subscribe() can decline - most commonly because maxSubscribers is already reached - and signals that only by leaving subscribedStreamer unset, so the assertions throw a TypeError out of a websocket message handler and bring the whole process down with them, disconnecting every other player. This is easiest to hit at --max_players 1, where the second player to send anything is by definition over the limit. Check the subscription took and disconnect that one player if it did not, which is what the branch above already does when there is no streamer to subscribe to at all. * chore: declare wilbur in the forced-subscribe crash changeset The fix ships to operators as Wilbur, so name it in the changeset rather than letting it land as a bare "updated dependencies" entry. Matches the two most recent Signalling changesets, which both list it alongside the library. --------- Co-authored-by: Matthew.Cotton <matt@tensorworks.com.au> (cherry picked from commit c6e78fb)
🦋 Changeset detectedLatest commit: 50da43b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mastertoUE5.8:Questions ?
Please refer to the Backport tool documentation