Merged
Conversation
ZhiyangSashaChen
approved these changes
Dec 2, 2025
fumlig
force-pushed
the
ol/release-backfill-assigned-tickets
branch
from
84650f3 to
4ce7797
Compare
slvmnd
approved these changes
Dec 2, 2025
Member
nhivo-embark
left a comment
nhivo-embark
left a comment
There was a problem hiding this comment.
Great change! Should we add some metrics to track them too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After tickets are assigned to new matches, they are deindexed and also released from the pending release set.
After backfill assignments, tickets are deindexed but never released. This has led to us accumulating ticket ids in the pending release set and therefore leaking memory.