Add ability to log loss/PPL per validation/test set#1392
Open
aflah02 wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
Tests pass locally :) |
Contributor
Author
|
Some changes in the last commit also fix other tests locally and are unrelated to the core PR but were existing bugs - Happy to move to another PR if that is preferred |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on Discord
The PR would benefit from first merging #1387, #1389 and #1356
These PRs fix eval which is currently fully broken and all runs crash when pipe parallel size is set to 1. One of the PRs also aligns args which is not contingent but would be nice to align args once and for all for future PRs.
In my testing it works well and logs separately as expected. Design Doc is just for reference and will be removed post review/ can be removed even before that if preferred