fix(psbt): reject trailing byte when parsing - #541
Closed
KY-U wants to merge 1 commit into
Closed
Conversation
Require wally_psbt_from_bytes to consume the complete input buffer. Add PSBT v0 and v2 regression test cases with a trailing byte.
3 tasks
Contributor
|
Thanks for contributing! I've included this in #542 which will be merged shortly, gated behind a parsing flag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wally_psbt_from_bytes()currently does not validate that the input buffer has been completely consumed. Since this API has no streaming or consumed-length interface, callers cannot distinguish the parsed PSBT from an unconsumed suffix.Rejecting unread bytes makes the contract unambiguous, as the caller will have certainty that the provided bytes correspond exactly to a valid PSBT.
This PR adds that validation and regression cases to the invalid PSBT test vectors.