Conversation
…ctricalAge into marcin212-minetweakersupport
Member
|
@Baughn: In order to get it to compile on travis without errors, you might need to select JDK8 like this: in .travis.yml. Seems Java 7 is still the default on travis... |
Contributor
|
Related: age-series/ElectricalAge#275 I found that there might be a bug in the removal code here, when I converted it to Kotlin. It only tries to check the Macerator recipes. |
jrddunbr
reviewed
Jun 21, 2023
| @Override | ||
| public void apply() { | ||
| toRemove = new ArrayList<Recipe>(); | ||
| for (Recipe r : Eln.instance.maceratorRecipes.getRecipes()){ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just @marcin212 's work, merged into the current version. It'll take a day or two to confirm that it works, then I'll merge it.
This change is