Skip to content

Ftr/120 Implement Navigator Web Component#164

Open
DennisFriedl wants to merge 12 commits intoEdirom:developfrom
korngold-werkausgabe:ftr/22-navigator-wc
Open

Ftr/120 Implement Navigator Web Component#164
DennisFriedl wants to merge 12 commits intoEdirom:developfrom
korngold-werkausgabe:ftr/22-navigator-wc

Conversation

@DennisFriedl
Copy link
Member

@DennisFriedl DennisFriedl commented Mar 6, 2026

Description, Context and related Issue

Refs #120

Only works in parallel to Edirom/Edirom-Online-Backend#146

Refactored the old Navigator logic, which got ready to render HTML from the backend (getNavigatorConfig), but now uses the new Navigator Web Component (https://github.com/Edirom/edirom-navigator)
The Navigator Web Component expects a JSON structure from the getNavigatorConfig (see Edirom/Edirom-Online-Backend#146) and then handles the transformation into HTML itself. For the user, the navigator should look pretty much the same.

The Web Component currently assumes that the edirom-icon Web Component from Edirom Core Web Components already gets called in the head of the host.

How Has This Been Tested?

Tested with the Edition Example, the Klarinettenquintett and Korngold internal data.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Improvement
  • Refactoring

Overview

Copy link
Contributor

@hizclick hizclick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing these changes, a window appears without any buttons or navigation controls.

Image

@github-project-automation github-project-automation bot moved this from In Progress to Changes Requested in Edirom Development Mar 13, 2026
@DennisFriedl
Copy link
Member Author

Have you tested this in parallel to the corresponding backend pull request: Edirom/Edirom-Online-Backend#146 ? What are the error messages? What does getNavigatorConfig respond?

@hizclick
Copy link
Contributor

Sorry, I tested it without git submodule update --init --recursive now I have the submodules and the buttons in the Control Bar are displayed but the navigator and edirom icons is are failing to load with 404 errors.

http://localhost:8080/exist/apps/Edirom-Online-Frontend/resources/web-components/edirom-core-web-components/src/edirom-icon.js

http://localhost:8080/exist/apps/Edirom-Online-Frontend/resources/web-components/edirom-core-web-components/src/edirom-icon.js

I think the reason is
``app/view/navigator/Navigator.js#L44-L50` references incorrect path:

  • References: resources/web-components/
  • Actual location: resources/js/ (where submodules are deployed)

@DennisFriedl
Copy link
Member Author

@hizclick you are absolutely correct. Sorry for that. I am mounting components to this path for local development and have not changed that yet.

@github-project-automation github-project-automation bot moved this from Changes Requested to Approved in Edirom Development Mar 16, 2026
@hizclick
Copy link
Contributor

Nice work!

@hizclick
Copy link
Contributor

@DennisFriedl, since we are planning to postpone PRs and API-related issues to the next release, and since merging Edirom/Edirom-Online-Backend#146 could introduce breaking changes, we should postpone this merge to the next release.

@hizclick hizclick modified the milestones: 1.3.0, 1.4.0 Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

2 participants