Ftr/120 Implement Navigator Web Component#164
Ftr/120 Implement Navigator Web Component#164DennisFriedl wants to merge 12 commits intoEdirom:developfrom
Conversation
for future centralization purposes
|
Have you tested this in parallel to the corresponding backend pull request: Edirom/Edirom-Online-Backend#146 ? What are the error messages? What does |
|
Sorry, I tested it without http://localhost:8080/exist/apps/Edirom-Online-Frontend/resources/web-components/edirom-core-web-components/src/edirom-icon.js http://localhost:8080/exist/apps/Edirom-Online-Frontend/resources/web-components/edirom-core-web-components/src/edirom-icon.js I think the reason is
|
|
@hizclick you are absolutely correct. Sorry for that. I am mounting components to this path for local development and have not changed that yet. |
|
Nice work! |
|
@DennisFriedl, since we are planning to postpone PRs and API-related issues to the next release, and since merging Edirom/Edirom-Online-Backend#146 could introduce breaking changes, we should postpone this merge to the next release. |

Description, Context and related Issue
Refs #120
Only works in parallel to Edirom/Edirom-Online-Backend#146
Refactored the old Navigator logic, which got ready to render HTML from the backend (getNavigatorConfig), but now uses the new Navigator Web Component (https://github.com/Edirom/edirom-navigator)
The Navigator Web Component expects a JSON structure from the getNavigatorConfig (see Edirom/Edirom-Online-Backend#146) and then handles the transformation into HTML itself. For the user, the navigator should look pretty much the same.
The Web Component currently assumes that the
edirom-iconWeb Component from Edirom Core Web Components already gets called in the head of the host.How Has This Been Tested?
Tested with the Edition Example, the Klarinettenquintett and Korngold internal data.
Types of changes
Overview