-
Notifications
You must be signed in to change notification settings - Fork 60
Remove builtin tokens #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
peachbits
wants to merge
14
commits into
master
Choose a base branch
from
matthew/builtin-tokens
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a475723
Describe how customTokenTemplate should be used
peachbits 8d51b03
Make sure enabled tokens exist in customTokens object
peachbits 88730ae
Use builtinTokens.json over accountState.builtinTokens for legacy fun…
peachbits 46dc32c
Make currencyCode access safer
peachbits 36a0d59
Remove builtinTokens
peachbits 98c9a50
Add isUserCreated to EdgeToken
peachbits 7613aff
Add addCustomTokens to CurrencyConfig
peachbits 7680874
fixup! Describe how customTokenTemplate should be used
peachbits 1b2fe7b
Revert "Make currencyCode access safer"
peachbits 3f9b5f3
Remove `balances`
peachbits 16784c4
fixup! Use builtinTokens.json over accountState.builtinTokens for leg…
peachbits 568b357
fixup! Remove builtinTokens
peachbits f3cda44
fixup! Remove builtinTokens
peachbits 8fbb8f0
fixup! Make sure enabled tokens exist in customTokens object
peachbits File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allTokens[pluginId]now undefined causing runtime crashesHigh Severity
The
allTokensreducer now returnsnext.self.customTokensdirectly, butcustomTokensonly contains entries for plugins that have explicitly stored tokens. The old reducer iterated over all currency plugins and created entries for each (even empty{}), guaranteeingallTokens[pluginId]was always an object. NowallTokens[pluginId]returnsundefinedfor any plugin without custom tokens. Multiple consumers accessallTokens[pluginId]without null guards — e.g.,changeEnabledTokenIdsdoesallTokens[tokenId]on the result, andgetCurrencyMultiplier/upgradeCurrencyCodecallObject.keys(allTokens)— all of which throwTypeErrorwhenallTokensisundefined. This affects non-token chains like Bitcoin and any wallet whose plugin has no migrated or user-created tokens yet.Additional Locations (1)
src/core/account/plugin-api.ts#L53-L58