This repository was archived by the owner on Aug 7, 2024. It is now read-only.
refactor: button component#10165
Draft
nexel-dev wants to merge 3 commits intoEddieHubCommunity:mainfrom
Draft
Conversation
Member
Author
|
Currently the all the button have default style if you approve that we should implement these library and use js doc for type safety I will replace all the button props from primary=true to variant=primary |
Member
|
This looks interesting, I am worried about the file limit with Vercel by adding more dependencies because are approaching the limit already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Changes proposed
Refactor button component
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers